Fix MMRDNP amplitudes
Main scope
The main scope of this merge request is to fix an implementation issue with MMRDNP, by introducing a parameter representing the reference time at which the complex amplitudes were calibrated to numerical relativity.
In this technical note we explain how the problem was introduced, how it was fixed and present a few tests to check the correctness of the new implementation.
The main review wiki is here.
Additional features
Apart from the amplitudes fix, in this merge request:
i) We add mass ordering to MMRDNP (see technical note);
ii) We add the (2,2,1) mode to MMRDNP (see technical note);
iii) We add a new prior option (flat in mass ratio) to MMRDNP, to facilitate comparison with IMR analyses of GW190521-like systems;
iv) We account for the reference time in all other models for which this is applicable (KHS_2012, MMRDNS).
Merge request reports
Activity
assigned to @gregorio.carullo
@vasco.gennari: what I wrote should be OK, but please double check since it's going to enter TEOBPM review once merged into master.
Edited by Gregorio Carullo
added 2 commits
added 3 commits
-
e4135004...2968dc06 - 2 commits from branch
master - a6d2a0d9 - Merge branch 'master' into MMRDNP-fix
-
e4135004...2968dc06 - 2 commits from branch
added 1 commit
- 7bb64f6b - Revert mass ordering constaint, before updated samples were not stored
The review for this fix is complete (pending any urgent comments from the reviewee). Review notes and comments may be found here. A link to the main review wiki may also be found there.
added 15 commits
-
7bb64f6b...a15a2a61 - 14 commits from branch
master - 3c65d547 - Merge branch 'master' into MMRDNP-fix
-
7bb64f6b...a15a2a61 - 14 commits from branch
enabled an automatic merge when the pipeline for 3c65d547 succeeds
mentioned in commit 02f18096
