Calcfap shouldn't error when given too many files
Done: We can launch calcfap with an arbitrary number of files. (or at least, handle the case more gracefully)
As noted in a comment when launching calcfap:
# reach the limit for maximum input string length
# when the number of banks reaches 140,
# it will give you a signal 7 error in OPA2
In this case, we're passing in a comma separated list of bankstats filenames as a string. If there's too many bankstats files, we launch combine_stats (presumably it doesn't need the list of files).
You could fix this by grabbing the files in the C program instead of python (We have fixmes on those python functions in the first place, both to reduce hardcoded filenames and to depend less on information encoded in filenames). Bit of a risk of that blowing out into a large refactor.
Or presumably there's a better way to pass the information to the subprocess.