Tune signal removal constants with O4 data
!148 (merged) signal_removal_bg
had a few constants to tune for O4:
- Newsnr q
- Newsnr n
- Signal removal newsnr threshold for BBH, BNS, and NSBH.
3 is ongoing, and has a new command line argument. 1 & 2 I'm unsure of, but there's a comment in the branch:
const float tunable_q = 6.0; // Tunable constants
const float tunable_n = 2.0; // Should be tuned with O4 data
which are constants for calculating new_snr. I'm not sure if these require further tuning or not, but I'm going to replace the comments with just // Tunable constants, see #<this issue>
.
If needed, we can add command line arguments for new_snr constants, or we can close this issue if they don't need further tuning.