Refactor LIGO_LW xmldoc handling to follow better standards
The way we construct (and delete) the CoincsDocFromPostcoh instances in postcoh_finalsink.py
is not particularly ideal nor pythonic, for example:
- the use of the lambda function
self.get_another
to instantiate itself inside its own__init__
method (as well asSegmentDocument
,PostcohDocument
, etc.) - the handling of deleting and creating
CoincsDocFromPostcoh
instances:
# at the end of FinalSink.__do_gracedb_alert
coincs_document = self.coincs_document.get_another()
del self.coincs_document
self.coincs_document = coincs_document
In general, LIGOLW XML Document handling should be refactored to be cleaner and more intuitive.
We would recommend reviewing this in tandem with #24.
Initially discussed during interval review, see: !44 (comment 562085).
Edited by Daniel Tang