Skip to content

GStreamer 1.0: Merge to MR81

Merged through to MR81. The snr series merge was reasonably difficult, as it turned out I our python module is now gstlal_spiir instead of gstlal in py3. So I've fixed an old import from relative to absolute path now I know that.

There's doubly likely a lingering issue with that adapter unmap, so I've left a FIXME. I have a fix almost ready, but not for this MR.

I recommend reviewing commit by commit. Note something went weird on the snr_series merge so it wound up with the changes as one commit and an empty merge after.

@luke.davis could you test using your finalsink patch to test the snr series upload? It may wind up being garbled, but it'd be a good test to start printing our snr series for this branch. Could you also throw together a patch to dump to disk on ozstar tests? Ideally as an MR, with a command line arg for gstreamer_python_upgrade, maybe more work though.

Tests

I've run tests here /fred/oz996/tdavies/spiir_project/sources/testing/gout/py3/MR108_tests/, run3 is with !81 (merged), runs 1 and 2 are before.

test_zerolags_25_11_MR108_MR108_v2.txt

test_zerolags_25_11_MR107_MR108.txt

test_zerolags_25_11_MR108_MR108.txt

Edited by Timothy Davies

Merge request reports