Skip to content

GStreamer 1.0: Various cleanups

Timothy Davies requested to merge tdavies__cleanup_py3 into gstreamer_python_upgrade

Related to #59

I've gone through the changeset and tried to simplify some things.

I went commit by commit, so it'll probably make sense to review it in the same way.

I can split it into multiple MRs if wanted, I just figure it'd become a lot of very simple reviews that might as well be combined here.

Changes

  • Addressed a note in _postcohtable.c: // Revisit after python upgrade
  • Updated a flag in _postcohtable.c that specified a numpy version to 1.23
  • Removed GObject.threads_init()
  • Removed debug output
  • Removed depcomp (it's generated on build)
  • Removed some old uncertain comments
  • Undo some formatting changes
  • Rearrange postcoh functions to simplify diffs
  • Update gstreamer version in configure.ac
  • Downgrade some fixmes & todos (careful reviewing this one, I can explain why I think these aren't critical)
  • Remove unused, reworked gstlal elements
  • Remove unused ACCELERATE_POSTCOH_MEMORY_COPY (pretty confident the new version does what the old version did but neater.)
  • Address one FIXME in postcoh (check there aren't conflicting pad caps)
  • Fix finalsink merge
  • Remove all __future__ python imports
  • Remove spiirparts-refactor.py

Testing

I'm running 2 8000 second injection tests here, and will do 2 before this MR for comparison.

Edited by Timothy Davies

Merge request reports