Skip to content

Move ifo_set to a shared module

Timothy Davies requested to merge tdavies__move_ifo_set_type into spiir-O4-EW-development

ifo_set is currently loitering in background_stats_utils, mostly because we didn't want to mess with automake at the time.

It should be used again for is_ifo_gap (it's another boolean array that corresponds to each ifo, so it might as well be an ifo_set)

I've moved it to the gst/lib folder, as I did for flag_segment.h.

There's a build issue I ran into with this and related changes: If you make some change to one of these common modules, you need to delete the install directory to rebuild. Sounds like some relative path is being used where it should be absolute?

I think that should be fixed separately, and it'll potentially take a while to track down. I'll make a new issue for it.

Tests

I've built (after deleting the old install directory) and have run an injection tests.

Results here /fred/oz016/tdavies/projects/testing/review/MR_146

Edited by Timothy Davies

Merge request reports