Skip to content

Gstreamer 1.0: Cleanup configure

Timothy Davies requested to merge tdavies__py3_cleanup_configure into gstreamer_python_upgrade

I've removed a bunch of changes to configure.ac, then tried building to see what was redundant. Looks like almost everything was redundant.

In addition, since I previously removed glib as a dependency of our cuda code, I tried removing any/all unnecessary cflags there.

I expected Something to fail, but nothing did. I've been pretty thorough about doing a git clean -fdx, git reset --hard HEAD, and deleting the old install directory. So seems like everything was actually unnecessary?

It may be worth adding some back in just in case we want to specify versions for our own code, even if we don't explicitly throw the CFLAGS/LIBs around?

e.g.

AC_SUBST([MIN_GLIB_VERSION], [2.0])
PKG_CHECK_MODULES([GLIB], [glib-2.0 >= ${MIN_GLIB_VERSION}])

Merge request reports