Skip to content

Record livetime and nevent per zerolag

Timothy Davies requested to merge tdavies__record_livetime_and_nevent into spiir-O4-EW-development

Related to #117, #60, #50

This MR adds columns for 'livetime' and 'nevent' to PostcohInspiralTable.
That includes columns for combined stats, and each detector.

The listed issues are a few motivators to do this. The main one is in ER-15, where we've seen a few issues with cohfar_assignfar. cohfar_assignfar.c sets far on each trigger only if we've collected at least 1 million backgrounds. However, in NSBH, we reach this threshold far too quickly and wind up uploading some noise triggers. In BBH, we take too long to reach 1 million backgrounds, and wind up waiting too long to start uploading after starting a run.

Before changing these thresholds, we should

  • Record the background in use for each trigger (this MR)
  • Record the FAR on all triggers (next MR)
  • Have finalsink make the upload decision based on livetime & nevent instead of cohfar_assignfar (next MR)

I've done an 8000s injection test, and it looks good (also turns out the 2h marginalized stats I use for most of my inj tests are empty, who knew).

Ideally this change and the next can be reviewed this month, and possibly make it into O4a, potentially with a change to the thresholds we use.

Merge request reports