Skip to content

Add arguments for signal removal

Timothy Davies requested to merge tdavies__add_args_for_signal_removal into signal_removal_bg

Just making this an MR to check a dev practice I'm wanting to push: Make command line arguments to enable/disable all the features that are done-pending-testing. At least for the major ones.

E.g. I'm wanting to merge this, Bypass, 1.4 snr threhsold, and maintain that practice for MRs going forward.

The idea being, we want one main development branch, and we're losing too much time and brainspace to merging things from O4 dev.

So, the proposal is, make command line args which enable each feature (with any other parameters to configure that feature). Default those to disable these features and merge once code review is satisfied. Once science testing is finalized, make an MR to default the feature to on (or remove the command line arg altogether).

We just need to make sure that we test with each feature enabled/disabled when making changes, or we could be breaking a disabled feature.

Merge request reports