Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • S spiir
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 73
    • Issues 73
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • spiir
  • Merge requests
  • !53

Refactor XML doc handling and subsequent GraceDb XML Upload

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Daniel Tang requested to merge refactor/gracedb_alert into spiir-O4-EW-development Sep 15, 2022
  • Overview 30
  • Commits 17
  • Pipelines 12
  • Changes 2

This PR is a first step to addressing #68.

At the moment, these changes only check if the gracedb_client object on FinalSink is not None. If it is None, we skip the upload, otherwise the code logic should execute as normal. Additionally, we are able to specify a maximum of n attempts to upload triggers to GraceDb, with the default specified to n=3.

The benefit of this change is simply that we don't run n trials to try to upload each trigger when we know there is no available gracedb client (such as on OzStar), ultimately saving time and minimising the amount of unnecessary messages we add to our logs.

Edited Jan 09, 2023 by Daniel Tang
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: refactor/gracedb_alert