Skip to content
Snippets Groups Projects
Commit 92651b0e authored by Marc Arene's avatar Marc Arene
Browse files

Correcting git push errors:

- comment lines 234 and 284 were too long
- line 236: missing whitespace around operator
parent 616096bd
No related branches found
No related tags found
No related merge requests found
Pipeline #87010 failed
......@@ -231,9 +231,14 @@ def _base_lal_cbc_fd_waveform(
delta_frequency = frequency_array[1] - frequency_array[0]
# One might want to set `maximum_frequency` to zero since in lalsimulation that corresponds to a computation of fEnd up to the ISCO frequency (for TaylorF2 approximant at least), cf https://lscsoft.docs.ligo.org/lalsuite/lalsimulation/_l_a_l_sim_inspiral_taylor_f2_8c_source.html#l00546
# Doing this results in `frequency_bounds` being False everywhere which is problematic !
if maximum_frequency==0:
# One might want to set `maximum_frequency` to zero since in
# lalsimulation that corresponds to a computation of fEnd up to
# the ISCO frequency (for TaylorF2 approximant at least),
# cf https://lscsoft.docs.ligo.org/lalsuite/lalsimulation/
#_l_a_l_sim_inspiral_taylor_f2_8c_source.html#l00546
# Doing this results in `frequency_bounds` being False everywhere
# which is problematic !
if maximum_frequency == 0:
frequency_bounds = ((frequency_array >= minimum_frequency) *
(frequency_array <= frequency_array[-1]))
else:
......@@ -281,7 +286,12 @@ def _base_lal_cbc_fd_waveform(
h_cross = np.zeros_like(frequency_array, dtype=np.complex)
if len(hplus.data.data) > len(frequency_array):
# For me that case should not be an error since IMRPhenomPv2 for instance outputs waveforms which array_length is a power of two and are padded with zeros from maximum_frequency up to the end of the array. Since this "next power of two" array-length rule is not used in bilby, it happens that the lalsim waveform in longer than our frequency_array
# For me that case should not be an error since IMRPhenomPv2
# for instance outputs waveforms which array_length is a power
# of two and are padded with zeros from maximum_frequency up
# to the end of the array. Since this "next power of two"
# array-length rule is not used in bilby, it happens that
# the lalsim waveform in longer than our frequency_array
# raise ValueError("Waveform longer than frequency array")
h_plus = hplus.data.data[:len(h_plus)]
h_cross = hcross.data.data[:len(h_cross)]
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment