Skip to content
Snippets Groups Projects

Fix registration in publisher, handle data_type attribute in Channel better

Merged Patrick Godwin requested to merge patrick.godwin/arrakis-python:client_publish into main
1 unresolved thread

Not sure why/how the properties handling in registration wasn't an issue before, perhaps the Flight API had changed, but this fixes an issue where the resulting data from a publish request wasn't being unpacked into the properties dict properly.

Also in the process, the publish example in the README had an issue where the metadata accepted in Channels did not accept raw numpy types well, as they do not have the name attribute. Forcing a cast within the Channel class handles this well, since converting a raw numpy type gives a numpy.dtype object, but converting an already existing numpy.dtype object is a no-op.

Merge request reports

Pipeline #682348 passed

Pipeline passed for 6b7ac615 on patrick.godwin:client_publish

Test coverage 42.10% (-0.10%) from 1 job
Approved by

Merged by Patrick GodwinPatrick Godwin 3 months ago (Nov 21, 2024 5:07pm UTC)

Loading

Pipeline #682355 passed

Pipeline passed for 7092c6a9 on main

Test coverage 42.10% (-0.10%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading