Skip to content

Changes

Page history
Update Code review authored by ABHIRUP GHOSH's avatar ABHIRUP GHOSH
Show whitespace changes
Inline Side-by-side
Code-review.md
View page @ 0f820194
......@@ -15,6 +15,7 @@
| `lalinference/src/LALInferenceInitCBC.c` |[Details](https://git.ligo.org/nv.krishnendu/lalsuite/wikis/Code-review#lalinferencesrclalinferenceinitcbcclalinferencesrclalinferenceproposalclalinferencesrclalinferencetemplatec)|:x:|
| `lalinference/src/LALInferenceProposal.c` |[Details](https://git.ligo.org/nv.krishnendu/lalsuite/wikis/Code-review#lalinferencesrclalinferenceinitcbcclalinferencesrclalinferenceproposalclalinferencesrclalinferencetemplatec)|:x:|
| `lalinference/src/LALInferenceTemplate.c` |[Details](https://git.ligo.org/nv.krishnendu/lalsuite/wikis/Code-review#lalinferencesrclalinferenceinitcbcclalinferencesrclalinferenceproposalclalinferencesrclalinferencetemplatec)|:x:|
| Sampling Sanity checks||:x:|
## Build details
......@@ -42,8 +43,8 @@
| Tasks| Status |
|---|---|
| Posteriors on all 4 non-GR parameters |:x: |
| Priors on all 4 non-GR parameters |:x: |
| Binning appropriate |:x: |
| Labels correct |:x: |
### `lalinference/src/LALInference.c` and `lalinference/src/LALInference.h`
......@@ -76,14 +77,13 @@ plt.ylabel('$\delta \kappa _A$')
| | Tasks| Status |
|---|---|---|
| 1. | Priors on all 4 non-GR parameters |:x:|
| 2. | fix-params should fix the posterior at tmp-value |:white_check_mark: |
| 3. | `fprintf(stdout,"Both options (from 12 and SA) are given . . Exiting . .\n");` | :white_check_mark: |
| 4. | `fprintf(stdout,"Only one option (from 12 and SA) is given . . Working fine . .\n");` | :white_check_mark:|
| 5. | `fprintf(stdout,"Both dQuadMonS and dQaudMonA are sampled");` | :white_check_mark: |
| 6. | `fprintf(stdout,"dQM1: %e, dQM2: %e, dQMS: %e, dQMA: %e \n",dQuadMon1,dQuadMon2,dQuadMonS,dQuadMonA);`| :white_check_mark: |
| 7. | `fprintf(stdout,"Both dQuadMon1 and dQaudMon2 are sampled");`| :white_check_mark:|
| 8. | `fprintf(stdout,"dQM1: %e, dQM2: %e \n",dQuadMon1,dQuadMon2);` | :white_check_mark: |
| 1. | fix-params should fix the posterior at tmp-value |:white_check_mark: |
| 2. | `fprintf(stdout,"Both options (from 12 and SA) are given . . Exiting . .\n");` | :white_check_mark: |
| 3. | `fprintf(stdout,"Only one option (from 12 and SA) is given . . Working fine . .\n");` | :white_check_mark:|
| 4. | `fprintf(stdout,"Both dQuadMonS and dQaudMonA are sampled");` | :white_check_mark: |
| 5. | `fprintf(stdout,"dQM1: %e, dQM2: %e, dQMS: %e, dQMA: %e \n",dQuadMon1,dQuadMon2,dQuadMonS,dQuadMonA);`| :white_check_mark: |
| 6. | `fprintf(stdout,"Both dQuadMon1 and dQaudMon2 are sampled");`| :white_check_mark:|
| 7. | `fprintf(stdout,"dQM1: %e, dQM2: %e \n",dQuadMon1,dQuadMon2);` | :white_check_mark: |
**Different sampling scenarios:**
......@@ -98,7 +98,7 @@ plt.ylabel('$\delta \kappa _A$')
Reference Injection file: [S190814bv.xml](uploads/1e189529dbc83ded65aac7a1bfca84a2/S190814bv.xml)
#### Task 3
#### Task 2
LALInference Command and output:
......@@ -111,7 +111,7 @@ XLAL Error - LALInferenceInitCBCModel (LALInferenceInitCBC.c:1451): Invalid argu
Segmentation fault: 11
```
### Task 4-8
### Task 3-7
**--dQuadMon12**
......@@ -194,6 +194,13 @@ Both dQuadMon1 and dQaudMon2 are sampleddQM1: 0.000000e+00, dQM2: -7.584580e+01
* --dQuadMonSA --fix-dQuadMonS 0.0
* --dQuadMon12 --fix-dQuadMon2 0.0
### Sampling Checks
|Tasks|Results|Status|
|--|--|--|
|Reproducing GR results from master||:x:|
|Zero-loglikelihood runs to check nature of all 4 priors ||:x:|
## Notes on the codes
* There seems to be an inconsistency between naming the variables with lower and upper case: "dquadmona" vs "dQuadMon1". The post-processing scripts have lower case, while the sampling scripts have upper case. `Clarify with Krishnendu`.
......