Skip to content

Changes

Page history
Update Code review authored by ABHIRUP GHOSH's avatar ABHIRUP GHOSH
Show whitespace changes
Inline Side-by-side
Code-review.md
View page @ c8da56b6
...@@ -195,10 +195,9 @@ Both dQuadMon1 and dQaudMon2 are sampleddQM1: 0.000000e+00, dQM2: -7.584580e+01 ...@@ -195,10 +195,9 @@ Both dQuadMon1 and dQaudMon2 are sampleddQM1: 0.000000e+00, dQM2: -7.584580e+01
| `lalinference/src/LALInferenceProposal.c` | . | . | | `lalinference/src/LALInferenceProposal.c` | . | . |
| `lalinference/src/LALInferenceTemplate.c` | | | | `lalinference/src/LALInferenceTemplate.c` | | |
### Notes on the codes ## Notes on the codes
* There seems to be an inconsistency between naming the variables with lower and upper case: "dquadmona" vs "dQuadMon1". The post-processing scripts have lower case, while the sampling scripts have upper case. `Clarify with Krishnendu`. * There seems to be an inconsistency between naming the variables with lower and upper case: "dquadmona" vs "dQuadMon1". The post-processing scripts have lower case, while the sampling scripts have upper case. `Clarify with Krishnendu`.
### Comments
* Newline characters missing at the end of Lines 237,245,270,278,309 and 317 in [diff.patch](https://git.ligo.org/nv.krishnendu/lalsuite/commit/7ec7378129a05b343dcf5d088f97426e41321949). `Action Item` * Newline characters missing at the end of Lines 237,245,270,278,309 and 317 in [diff.patch](https://git.ligo.org/nv.krishnendu/lalsuite/commit/7ec7378129a05b343dcf5d088f97426e41321949). `Action Item`
......