... | @@ -54,7 +54,7 @@ To check the readiness of this pipeline for the analysis of O3 events. |
... | @@ -54,7 +54,7 @@ To check the readiness of this pipeline for the analysis of O3 events. |
|
|
|
|
|
# Detail of the modifications
|
|
# Detail of the modifications
|
|
|
|
|
|
- Git hash of the branch to be reviewed: 5157eea61128250568beca71edbc18c165a4a45e
|
|
- Git hash of the branch to be reviewed: 08e05a526d3e2bca780bf4fa08fa83df85209d51
|
|
|
|
|
|
| Files modified |Lines changed| Short explanation | Person Responsible | Reviewer Response | Addressing Issue (if any) |
|
|
| Files modified |Lines changed| Short explanation | Person Responsible | Reviewer Response | Addressing Issue (if any) |
|
|
| -------- | --- | ----- | -------- | -------- | -------- |
|
|
| -------- | --- | ----- | -------- | -------- | -------- |
|
... | @@ -68,7 +68,7 @@ To check the readiness of this pipeline for the analysis of O3 events. |
... | @@ -68,7 +68,7 @@ To check the readiness of this pipeline for the analysis of O3 events. |
|
|[bayespputils.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py) | [L148](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py#L148) and [L484](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py#L484)| Created a list `spin_induced_quad_terms` and added this to `strongFieldParams` <br> Created corresponding plot labels inside `plot_label(param)` |Abhirup & Anuradha G. |**Gupta**: looks good. <br> **Abhirup**: looks good.| -------- |
|
|
|[bayespputils.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py) | [L148](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py#L148) and [L484](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py#L484)| Created a list `spin_induced_quad_terms` and added this to `strongFieldParams` <br> Created corresponding plot labels inside `plot_label(param)` |Abhirup & Anuradha G. |**Gupta**: looks good. <br> **Abhirup**: looks good.| -------- |
|
|
|
|
|
|
## A detailed summary of revisions made to the review branch:
|
|
## A detailed summary of revisions made to the review branch:
|
|
- Commit-3: git hash: 8b1af14cba97cee8570201704c6917c42a89a97b. Separated the dDquadMon params from the testing GR params. Sampling options now allowd are; for the one parameter case any of the four parameters cane be sampled (one has to fix the other parameter using fix-parameters). <br> For the two parameter case, either {dQuadMon1, dQuadMon2} or {dQuadMonS, dQuadMonA}. <br> If one passes more than two parameters, the run will end with a exist message. Default prior on these parameters will be [-200, 200].
|
|
- Commit-3: git hash: 08e05a526d3e2bca780bf4fa08fa83df85209d51. Separated the dQuadMon params from the testing GR params. Sampling options now allowd are; for the one parameter case any of the four parameters cane be sampled (one has to fix the other parameter using fix-parameters). <br> For the two parameter case, either {dQuadMon1, dQuadMon2} or {dQuadMonS, dQuadMonA}. <br> If one passes more than two parameters, the run will end with a exist message. Default prior on these parameters will be [-200, 200].
|
|
- Commit-2: git hash: 95cc718a46e09c2f2eb7fe33090c8cfdc7aff468. Very generic sampling options are introduced. <br>1. If one parameter is passed among the four dQuadMon parameters, one would be able to sample on dQuadMon1, dQuadMon2, dQuadMonS or dQuadMonA individually. <br> 2. For the two parameter case, either dQuadMon1 and dQuadMon2 or dQuadMonS and dQuadMonA can be sampled. If any other combination is passed, sampling will be done on dQuadMon1 and dQuadMon2 (dafault option) with a warning message. Mainly `lalinference/src/LALInferenceInitCBC.c` and `lalinference/src/LALInferenceTemplate.c` are changed.
|
|
- Commit-2: git hash: 95cc718a46e09c2f2eb7fe33090c8cfdc7aff468. Very generic sampling options are introduced. <br>1. If one parameter is passed among the four dQuadMon parameters, one would be able to sample on dQuadMon1, dQuadMon2, dQuadMonS or dQuadMonA individually. <br> 2. For the two parameter case, either dQuadMon1 and dQuadMon2 or dQuadMonS and dQuadMonA can be sampled. If any other combination is passed, sampling will be done on dQuadMon1 and dQuadMon2 (dafault option) with a warning message. Mainly `lalinference/src/LALInferenceInitCBC.c` and `lalinference/src/LALInferenceTemplate.c` are changed.
|
|
- Commit-1: git hash: 5157eea61128250568beca71edbc18c165a4a45e. This is the first commit. Main changes suggested by the reviewers to fix the sampling parameters choice related confusion and to fix the typoes in the plotting script.
|
|
- Commit-1: git hash: 5157eea61128250568beca71edbc18c165a4a45e. This is the first commit. Main changes suggested by the reviewers to fix the sampling parameters choice related confusion and to fix the typoes in the plotting script.
|
|
|
|
|
... | | ... | |