Home.md

@@ -75,11 +75,11 @@ To check the readiness of this pipeline for the analysis of O3 events.
 |[cbcBayesPostProc.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/cbcBayesPostProc.py) | [L1167](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesPostProc.py#L1167)| Using the spin-induced quadrupole moment parameters defined in `lalinference.bayespputils` |Abhirup & Anuradha G. |**Gupta**: looks good.  <br> **Abhirup**:  | -------- |
 
 ## A detailed summary of revisions made to the review branch:
-- Commit-5: git hash: 8f92f486d94c27ac1f40bdb970cf63398e8a6835. This was mainly to solve a convention issue and the changes were made to `lalsimulation/lib/LALSimIMRPhenomP.c`. Brief description of the problem is here. That is if we use PhenomPv2/PhenomPv3/PhenomPv3HM/PhenomPXHM for sampling the SIQM parameter corresponds to the low mass BH(dQuadMon2) will be better constrained compared to the SIQM parameter corresponds to the heavier mass BH(dQuadMon1). If we look into more details, the PhenomP waveforms internally assume m2>m1 and forcefully flip the mass parameters if it is not the case as done [here](https://git.ligo.org/nv.krishnendu/lalsuite/-/blob/SIQM_rebase/lalsimulation/lib/LALSimIMRPhenomP.c#L651)
+- Commit-5: git hash: 8f92f486d94c27ac1f40bdb970cf63398e8a6835. This was mainly to solve a convention issue and the changes were made to `lalsimulation/lib/LALSimIMRPhenomP.c`. So, if we use PhenomPv2/PhenomPv3/PhenomPv3HM/PhenomPXHM for sampling the SIQM parameter corresponds to the low mass BH(dQuadMon2) will be better constrained compared to the SIQM parameter corresponds to the heavier mass BH(dQuadMon1). If we look into more details, the PhenomP waveforms internally assume m2>m1 and forcefully flip the mass parameters if it is not the case as done [here](https://git.ligo.org/nv.krishnendu/lalsuite/-/blob/SIQM_rebase/lalsimulation/lib/LALSimIMRPhenomP.c#L651)
 For masses and spins, there is no confusion and at the stage of lalinference samples, we get samples with m1>m2. So, the m2>m1 assumption is only valid inside this code, and everywhere else these parameters are consistently flipped back. In our case, the initial values are fixed to the default BH values in [this code](https://git.ligo.org/nv.krishnendu/lalsuite/-/blob/SIQM_rebase/lalsimulation/lib/LALSimIMRPhenomP.c#L632)
 and the lines [here](https://git.ligo.org/nv.krishnendu/lalsuite/-/blob/SIQM_rebase/lalsimulation/lib/LALSimIMRPhenomP.c#L668) are not swapping anything. The only case where the flipping happened is in the case of [PhenomPv2_NRTidal waveforms]( https://git.ligo.org/nv.krishnendu/lalsuite/-/blob/SIQM_rebase/lalsimulation/lib/LALSimIMRPhenomP.c#L635)
-where the  dQuadMon1-dQuadMon2 parameters are also redefined as ['LookUpparams'](https://git.ligo.org/nv.krishnendu/lalsuite/-/blob/SIQM_rebase/lalsimulation/lib/LALSimIMRPhenomP.c#L641).
-- Commit-4: git hash: 2ecaaf92993deb667060570718d311b0a958de32. Modifications to `lalsimulation/lib/LALSimInspiralTestGRParams.c` to fix a bug which was affecting the MCMC sampling. This is done for all the TGR parameters. Please see details here:ADD/ASK 
+where the  dQuadMon1-dQuadMon2 parameters are also redefined as ['LookUpparams'](https://git.ligo.org/nv.krishnendu/lalsuite/-/blob/SIQM_rebase/lalsimulation/lib/LALSimIMRPhenomP.c#L641). [wiki-page](https://git.ligo.org/nv.krishnendu/lalsuite/-/wikis/wf-regression-tests) with more details. Careful waveform tests are required for integration with master and not part of the MR.
+- Commit-4: git hash: 2ecaaf92993deb667060570718d311b0a958de32. Modifications to `lalsimulation/lib/LALSimInspiralTestGRParams.c` to fix a bug which was affecting the MCMC sampling. This is done for all the TGR parameters. With the new waveform interface introduced in O3, sampled over tidal or TGR parameters not listed in LALSimInspiralTestGRParams.c (i.e. [here](https://git.ligo.org/lscsoft/lalsuite/-/blob/master/lalsimulation/lib/LALSimInspiralTestGRParams.c#L189), but in the LAL installation that was actually used in the run). So one has to update this list [here](https://git.ligo.org/lscsoft/lalsuite/-/blob/master/lalinference/lib/LALInferenceProposal.c#L98). Email exchange with John Veitch to confirm this. 
 - Commit-3: git hash: 08e05a526d3e2bca780bf4fa08fa83df85209d51. Separated the dQuadMon params from the testing GR params. Sampling options now allowd are; for the one parameter case any of the four parameters cane be sampled (one has to fix the other parameter using fix-parameters). <br> For the two parameter case, either {dQuadMon1, dQuadMon2} or {dQuadMonS, dQuadMonA}. <br> If one passes more than two parameters, the run will end with a exist message. Default prior on these parameters will be [-200, 200].
 - Commit-2: git hash: 95cc718a46e09c2f2eb7fe33090c8cfdc7aff468. Very generic sampling options are introduced. <br>1. If one parameter is passed among the four dQuadMon parameters, one would be able to sample on dQuadMon1, dQuadMon2, dQuadMonS or dQuadMonA individually.  <br> 2. For the two parameter case, either dQuadMon1 and dQuadMon2 or dQuadMonS and dQuadMonA can be sampled. If any other combination is passed, sampling will be done on dQuadMon1 and dQuadMon2 (dafault option) with a warning message. Mainly `lalinference/src/LALInferenceInitCBC.c` and `lalinference/src/LALInferenceTemplate.c` are changed.
 - Commit-1: git hash: 5157eea61128250568beca71edbc18c165a4a45e. This is the first commit. Main changes suggested by the reviewers to fix the sampling parameters choice related confusion and to fix the typoes in the plotting script.