Possible return order bug in calculate_point_estimate_sigma_spectra
Is the return order correct below?
var_fs = var_fs * w1w2squaredbar / w1w2bar ** 2
if csd is not None:
Y_fs = (csd) / (orf * S_alpha)
return Y_fs, var_fs
else:
return var_fs
I would think you would want to return var_fs
first in the first part of the if
statement so that the order of returned arguments is consistent in both cases ie. either var_fs
alone or var_fs, Y_fs
in that order.
Note that it is used in the form Y_fs, var_fs
in baseline.py
so that needs to also maintain consistency if this is changed.