Skip to content

Unify psd csd calculations: addressing #69

Arianna Renzini requested to merge arianna.renzini/pygwb:unify_psd_csd_calc into master

This MR essentially addresses #69 (closed) and unifies the PSD and CSD calculations; with some care, the PSD is now a CSD and can be either coarse-grained or welch-averaged. None of the defaults have changed, but this helps us keep track of the calculations more efficiently.

This will also be helpful for:

  • stochmon: CSDs and PSDs should be calculated the same way, otherwise coherences can be coh > 1 @derek.davis
  • SSI: similarly to stochmon, I think that as we perform operations of the type a*CSD - b*PSD, these can't be calculated with two different averaging procedures... @jessica.lawrence @kevin.turbang

Merge request reports