Skip to content

WIP: Selection function compatibility

Amanda Farah requested to merge selection_func_compat into master

Right now, SamplingDistribution/RedshiftDistributions don't work as inputs to the gwpopulation selection function. Both gwdist and gwpop need to be modified for them to be compatible.

So far, I can tell a few things that need to be changed and are started to be changed in this MR:

  1. RedshiftDistribution needs to have a total_spacetime_volume() method
  2. In order to do this, the child classes need to a have a psi_of_z() method (unless its easier to make them each have their own total_spacetime_volume)

Note that this is very rough and the solutions here are hackey - please feel free to modify at will if you have more elegant solution!

Merge request reports