| ... | ... | @@ -33,7 +33,7 @@ This review wiki covers the changes to the code based in order to incorporate po |
|
|
|
* [X] code can be run with minimal adjustments by cloning the repo
|
|
|
|
- Review statement: The `README` is slightly outdated in the repo, but error messages are informative and getting a working command is straightforward - see "Quantitative Results" section below for working commands run and corresponding output.
|
|
|
|
|
|
|
|
### Additional checklist items for addition of spin inference
|
|
|
|
## Additional checklist items for addition of spin inference
|
|
|
|
|
|
|
|
* [ ] inference reproduces the same results when spins are neglected (--spin-column is not passed) and when spins are identically zero for all samples
|
|
|
|
* [ ] inference produces strictly larger estimates for P(m2<Mmax) when spins are included (but known to be less than the break-up spin) compared to when spins are neglected
|
| ... | ... | @@ -42,7 +42,7 @@ This review wiki covers the changes to the code based in order to incorporate po |
|
|
|
* [ ] estimate of maximum spin based on (Mtov, Rtov) is correctly implemented based on Eqn 17 of [Breu+Rezzolla 2016](https://academic.oup.com/mnras/article/459/1/646/2608837)
|
|
|
|
* [ ] the (updated) code can be run with minimal changes by cloning the repo
|
|
|
|
|
|
|
|
## Quantitative Results
|
|
|
|
# Quantitative Results
|
|
|
|
using `master` at [1f035f47](https://git.ligo.org/reed.essick/mmax-model-selection/-/commit/1f035f47c04ddd4c7f69947b96ff0c759479b68d) I get:
|
|
|
|
```
|
|
|
|
$ python bin/mmax-model-selection -v etc\combined_PHM.csv etc/mmax_spec.csv --m1-column mass_1 --m2-column mass_2 --mmax-column Mmax --mass-column mass_2_source --d-column luminosity_distance --d-range 0 500 --q-range 0.02 0.25 --mc-range 6.0 7.0 --m-range 1.0 54.5 --population-parameter dmin 0.0 -P dmax 500
|
| ... | ... | |
