... | @@ -2,6 +2,14 @@ |
... | @@ -2,6 +2,14 @@ |
|
|
|
|
|
This review wiki covers the changes to the code based in order to incorporate population priors (as opposed to the default LALInference prior) as well as associated updates to the error estimation.
|
|
This review wiki covers the changes to the code based in order to incorporate population priors (as opposed to the default LALInference prior) as well as associated updates to the error estimation.
|
|
|
|
|
|
|
|
Review Checklist
|
|
|
|
|
|
|
|
* [ ] Formalism described in [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) is correct
|
|
|
|
* [ ] Monte-Carlo point-estimates and error estimates derived in [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) are correct
|
|
|
|
* [ ] Monte-Carlo algorithms are correctly implemented within calls to [utils.prob_odds](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/mmax_model_selection/utils.py#L335)
|
|
|
|
* [ ] population priors are correctly implemented within calls to [utils.population_weights](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/mmax_model_selection/utils.py#L107)
|
|
|
|
* [ ] reweighting of single-event posterior samples is by population priors is correctly done within the [mmax-model-selection executable](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/bin/mmax-model-selection#L138)
|
|
|
|
|
|
## Motivation
|
|
## Motivation
|
|
|
|
|
|
The calculation is still structured in the same basic way as before (compare [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) to [LIGO-T1900552](https://dcc.ligo.org/LIGO-T1900552) and [LIGO-T2000097](https://dcc.ligo.org/T2000097)).
|
|
The calculation is still structured in the same basic way as before (compare [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) to [LIGO-T1900552](https://dcc.ligo.org/LIGO-T1900552) and [LIGO-T2000097](https://dcc.ligo.org/T2000097)).
|
... | | ... | |