... | @@ -2,7 +2,22 @@ |
... | @@ -2,7 +2,22 @@ |
|
|
|
|
|
This review wiki covers the changes to the code based in order to incorporate population priors (as opposed to the default LALInference prior) as well as associated updates to the error estimation.
|
|
This review wiki covers the changes to the code based in order to incorporate population priors (as opposed to the default LALInference prior) as well as associated updates to the error estimation.
|
|
|
|
|
|
Review Checklist
|
|
[[_TOC_]]
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
# Review
|
|
|
|
|
|
|
|
## Reviewers
|
|
|
|
|
|
|
|
* Jolien Creighton (jolien@uwm.edu)
|
|
|
|
|
|
|
|
## Reveiwees
|
|
|
|
|
|
|
|
* Reed Essick (reed.essick@gmail.com)
|
|
|
|
* Phil Landry (pgjlandry@gmail.com)
|
|
|
|
|
|
|
|
# Review Checklist
|
|
|
|
|
|
* [ ] Formalism described in [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) is correct
|
|
* [ ] Formalism described in [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) is correct
|
|
* [ ] Monte-Carlo point-estimates and error estimates derived in [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) are correct
|
|
* [ ] Monte-Carlo point-estimates and error estimates derived in [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) are correct
|
... | @@ -10,14 +25,16 @@ Review Checklist |
... | @@ -10,14 +25,16 @@ Review Checklist |
|
* [ ] population priors are correctly implemented within calls to [utils.population_weights](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/mmax_model_selection/utils.py#L107)
|
|
* [ ] population priors are correctly implemented within calls to [utils.population_weights](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/mmax_model_selection/utils.py#L107)
|
|
* [ ] reweighting of single-event posterior samples is by population priors is correctly done within the [mmax-model-selection executable](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/bin/mmax-model-selection#L138)
|
|
* [ ] reweighting of single-event posterior samples is by population priors is correctly done within the [mmax-model-selection executable](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/bin/mmax-model-selection#L138)
|
|
|
|
|
|
## Motivation
|
|
---
|
|
|
|
|
|
|
|
# Motivation
|
|
|
|
|
|
The calculation is still structured in the same basic way as before (compare [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) to [LIGO-T1900552](https://dcc.ligo.org/LIGO-T1900552) and [LIGO-T2000097](https://dcc.ligo.org/T2000097)).
|
|
The calculation is still structured in the same basic way as before (compare [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) to [LIGO-T1900552](https://dcc.ligo.org/LIGO-T1900552) and [LIGO-T2000097](https://dcc.ligo.org/T2000097)).
|
|
In particular, we implement a Monte-Carlo integral via two nested loops to estimate an upper limit on the posterior probability that an object is a NS by asserting perfect knowledge of the overall mass distribution and assuming that everything below Mmax is a NS. A more thorough discussion of the assumptions and limitations are available in [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372).
|
|
In particular, we implement a Monte-Carlo integral via two nested loops to estimate an upper limit on the posterior probability that an object is a NS by asserting perfect knowledge of the overall mass distribution and assuming that everything below Mmax is a NS. A more thorough discussion of the assumptions and limitations are available in [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372).
|
|
|
|
|
|
The considerations within [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) forced us to modify the code in several ways (see below) to estimate the impact of different overall mass distributions along with updated error estimates from the Monte-Carlo integrals.
|
|
The considerations within [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) forced us to modify the code in several ways (see below) to estimate the impact of different overall mass distributions along with updated error estimates from the Monte-Carlo integrals.
|
|
|
|
|
|
## Changes to Implementation
|
|
# Changes to Implementation
|
|
|
|
|
|
Here, we briefly review the changes in the code relative to what was reviewed as part of the [GW190814 effort](GW190814-Review). The code changed in two main ways
|
|
Here, we briefly review the changes in the code relative to what was reviewed as part of the [GW190814 effort](GW190814-Review). The code changed in two main ways
|
|
|
|
|
... | @@ -26,7 +43,7 @@ Here, we briefly review the changes in the code relative to what was reviewed as |
... | @@ -26,7 +43,7 @@ Here, we briefly review the changes in the code relative to what was reviewed as |
|
|
|
|
|
In particular, we can see changes to the code relative to what was used for the GW190814 detection paper in [this comparison](https://git.ligo.org/reed.essick/mmax-model-selection/-/compare/1b0411beb7288d88b16bdd5c281caa09f5ceb755...master).
|
|
In particular, we can see changes to the code relative to what was used for the GW190814 detection paper in [this comparison](https://git.ligo.org/reed.essick/mmax-model-selection/-/compare/1b0411beb7288d88b16bdd5c281caa09f5ceb755...master).
|
|
|
|
|
|
### Library Structure
|
|
## Library Structure
|
|
|
|
|
|
The library consists of a single executable (`mmax-model-selection`) which relies on a single module (`utils.py`). The only external dependencies are `numpy` and standard Python modules. The library can be installed with the standard syntax
|
|
The library consists of a single executable (`mmax-model-selection`) which relies on a single module (`utils.py`). The only external dependencies are `numpy` and standard Python modules. The library can be installed with the standard syntax
|
|
|
|
|
... | @@ -157,6 +174,6 @@ ouptut arguments: |
... | @@ -157,6 +174,6 @@ ouptut arguments: |
|
--outpath OUTPATH
|
|
--outpath OUTPATH
|
|
```
|
|
```
|
|
|
|
|
|
## Comparison to Previous Results
|
|
# Comparison to Previous Results
|
|
|
|
|
|
**WRITE ME** |
|
**WRITE ME** |
|
|
|
\ No newline at end of file |