Skip to content

Revert gstlal O4b changes to online data source.

Timothy Davies requested to merge tdv-revert-reblock into spiir_compatibility_fixes

When trying to run online after the latest update, we found that monitoring failed with the error:

10.9.2.175 - - [29/Mar/2024 04:17:46] "GET /L1/statevector_on.txt HTTP/1.1" 200 22
120 Traceback (most recent call last):
121   File "/usr/spiir/lib/python3.10/site-packages/gstlal/bottle.py", line 862, in _handle
122     return route.call(**args)
123   File "/usr/spiir/lib/python3.10/site-packages/gstlal/bottle.py", line 1732, in wrapper
124     rv = callback(*a, **ka)
125   File "/usr/spiir/lib/python3.10/site-packages/gstlal/datasource.py", line 1170, in strain_add
126     add = elem.get_property("add")
127 TypeError: object of type `GSTLALReblock' does not have property `add'

We traced this back to a change added in the gstlal O4b review tag (compared to the previous version we used), which added a reblock element around each part of the pipeline. Reblock elements help by breaking a long buffer into smaller chunks, e.g. from 2 seconds down to 1 second.

We already add our own reblock elements before and after whitening, so this change should be unnecessary for SPIIR. This MR removes the additional reblocks.

Merge request reports