Skip to content

Fix ordering of tee.

Timothy Davies requested to merge tdv-fix-frame-with-statevector into spiir_compatibility_fixes

Fix error found when running with offline Frames + DQ and State vectors:

 43 Traceback (most recent call last):
 44   File "/usr/spiir/lib/python3.10/site-packages/gstlal/pipeparts/source.py", line 81, in pad_added
 45     pad.link(sinkpad)
 46   File "/usr/spiir/lib/python3.10/site-packages/gi/overrides/Gst.py", line 204, in link
 47     raise LinkError(ret)
 48 gi.overrides.Gst.LinkError: <enum GST_PAD_LINK_WAS_LINKED of type Gst.PadLinkReturn>

I was supposed to do a Tee, before using the tee for an AudioRate and a Queue (into a gate). The gate continues as part of the main pipeline, the audiorate is supposed to be returned.

The Py2 code also put a queue after the AudioRate. I removed that since the latest GSTLAL version puts a 10 minute queue at the start instead. It's possible there should still be a queue (maybe a short one), I'm unsure.

If wrong, it'd affect performance, but should be valid. As it's offline, I'd say let's try as-is and add a queue if needed.

Requires testing.

Merge request reports