Approximant Naming
So we have this stuff to assign phase order in iwc_pipe
if pe_pnorder == 8 or pe_pnorder == -1:
pe_approx = pe_approx + 'pseudoFourPN'
elif pe_pnorder == 7:
pe_approx = pe_approx + 'threePointFivePN'
elif pe_pnorder == 6:
pe_approx = pe_approx + 'threePN'
elif pe_pnorder == 5:
pe_approx = pe_approx + 'twoPointFivePN'
elif pe_pnorder == 4:
pe_approx = pe_approx + 'twoPN'
But then here:
Traceback (most recent call last):
File "/home/johnmichael.sullivan/.conda/envs/igwn-testing-jack/bin/residuals.py", line 7, in <module>
exec(compile(f.read(), __file__, 'exec'))
File "/home/johnmichael.sullivan/src/igwn-wave-compare/scripts/residuals.py", line 197, in <module>
waveformsF = iwc.waveform.generate_strains_from_samples(li_samples,
File "/home/johnmichael.sullivan/src/igwn-wave-compare/igwn_wave_compare/waveform.py", line 357, in generate_strains_from_samples
apply_waveform_to_strain(strain, sim, ifo, f_ref=fref, f_lower=flow, phase_order=phase_order)
File "/home/johnmichael.sullivan/src/igwn-wave-compare/igwn_wave_compare/waveform.py", line 191, in apply_waveform_to_strain
signal = make_strain_from_inj_object(inj, delta_t,
File "/home/johnmichael.sullivan/src/igwn-wave-compare/igwn_wave_compare/waveform.py", line 245, in make_strain_from_inj_object
hp, hc = get_td_waveform(template=inj, approximant=name,
File "/home/johnmichael.sullivan/.conda/envs/igwn-testing-jack/lib/python3.10/site-packages/pycbc/waveform/waveform.py", line 552, in get_td_waveform
raise ValueError("Approximant %s not available" %
ValueError: Approximant IMRPhenomXPHMpseudoFourPN not available
I resolved this issue. But do we need this approximant-naming convention? Not sure what convention we're in here, but I'm leaving, for now.