Add mass2 and chi_eff to the reweighting script

No longer using my code for the PDB reweighting, just need to add mass2 and chi_eff to the reweighting script since those are being shown in the new figure.

requested review from @shanika.galaudage

These are the posteriors I get when I run this script on the PDB results: https://ldas-jobs.ligo.caltech.edu/~sylvia.biscoveanu/nsbh/S230529ay/pdb_reweighted.png

added 1 commit

• 38709dc3 - Fix prior

Compare with previous version

changed the description

In mattermost, you said we want to preform "the reweighting obtained using the one-left-out population-averaged posterior predictive distribution" but this file is the hyperposterior with the event included. I think you want no_230529_mass_h_result.json

the weighting method Sylvia is using needs the run with all the events, and then it weights out that event using Eq 46, so the full event result is correct.

changed this line in version 4 of the diff

Apologies if this is obvious, but where do you have gwpopulation.models.mass.power_law_dip_break()? You don't seem to have gwpopulation as a submodule to this repo. I'm sure I could find your fork of gwpopulation but I just want to make sure I go to the right branch and version, etc.

I made a provisional conda environment where I installed your fork of gwpopulation (from the pending MR that adds the power_law_dip_break model) just to make sure this works. But my plan was to just ask to source the conda environment you're using for the full PDB analysis to actually run the "production" version of this script.

added 1 commit

• a57c9efb - Add chi_eff

Compare with previous version

added 1 commit

• 3ccb9df6 - Remove PDB

Compare with previous version

changed title from Add PDB reweighting script to Add mass2 and chi_eff to the reweighting script

changed the description

Everything looks good @sylvia.biscoveanu!

mentioned in commit 327c5627

merged