Skip to content

Big update to the precessing model

Serguei Ossokine requested to merge antoni.ramos-buades/pyseobnr:rebase_onto_main into main

This is an amalgamation of many updates to the precessing model.

This MR fixes several bugs:

  • corrects a regression that resulted in wrong convention used for rotation of the modes
  • also corrects how the residual freedom from the minimal rotation condition is fixed
  • noise in the quaternions when J is collinear with L_N
  • super-kick configuration could give nans due to roundoff in final spin calculation

It also introduces new features:

  • QNM frequency shift from Hamilton+
  • Several code optimisations for speed
  • Now has draft analytic PA for precessing models (still being finalised for domain of applicability)

Merge request reports