Skip to content

Fix retrograde cases

Lorenzo Pompili requested to merge lorenzo.pompili/pyseobnr:fix-retrograde-2 into main

Fixes #22 (closed) by using the sign of the final spin (taken from the non-precessing fit with chi1_LN, chi2_LN) to consistently flip sign both for the final spin and for the post-merger extension of the Euler angles, for retrograde-spin cases.

The fix proposed in !69 (closed) causes issues in the aligned-spin limit, while this fix doesn't seem to give any problem.

Pending to be merged after rerunning standard sanity checks (e.g. as documented here https://git.ligo.org/waveforms/reviews/seobnrv5/-/wikis/tests_bug_fix_15052023) and mismatches with NR for configurations that are affected by the change.

Merge request reports