Skip to content

Refined interpolation to determine the reference time

Lorenzo Pompili requested to merge lorenzo.pompili/pyseobnr:tc-intrp into main

In the SEOBNRv5 models the reference time is given by the peak of the frame-invariant amplitude. To find the peak we currently take the corresponding index of the time array, sampled at the sampling rate used to return the waveform.

If using a low sampling rate, the "true" peak can be between two time samples, and the peak determined in this way can be slightly discontinuous across parameter space. This can lead to undesired behavior e.g. in Fisher matrix calculations or PE for high SNR signals.

This MR fixes this by interpolating on a finer grid (0.001 M) around [- delta_T, delta_T] to accurately determine the peak .

Before After
tpeak_pre_fix tpeak_post_fix

Notebook

Merge request reports

Loading