Adding functions with more general real-time/isolation language because this functionality extends to more general core isolation use-cases.
Adding functions with more general real-time/isolation language because this functionality extends to more general core isolation use-cases.
closes #334 (closed)
Merge request reports
Activity
requested review from @erik.vonreis and @jonathan-hanks
64 /// 65 /// All CPU_IDs are 0 indexed. 66 /// 67 #if LINUX_VERSION_CODE <= KERNEL_VERSION(5,6,0) 68 static inline int rts_isolator_exec( unsigned int CPU_ID ){ return cpu_down(CPU_ID); } 69 static inline int rts_isolator_cleanup( unsigned int CPU_ID ){ return cpu_up(CPU_ID); } 70 #else //This is 5.10.0 and newer, caller interface is the same between versions 71 static inline int rts_isolator_exec( unsigned int CPU_ID ){ return remove_cpu(CPU_ID); } 72 static inline int rts_isolator_cleanup( unsigned int CPU_ID ){ return add_cpu(CPU_ID); } 73 #endif 74 75 76 77 /// Other Notes 78 /// 79 ///TODO: Maybe we should just link to an example repository changed this line in version 2 of the diff
- src/drv/rts-cpu-isolator/.gitignore 0 → 100644
Need to manually close #334 (closed) when this merge request is merged, because I didn't link the two correctly.
@ezekiel.dohmen, you can just edit the issue description and add a 'closes #334 (closed)' to the description, that should do the trick. I'll go ahead and do that.
mentioned in commit 330d87f9
@ezekiel.dohmen I really like where you're going with this patch. The functionality here does not need to have this overly obscure names. But why not fix
set_fe_code_idleandligo_play_deadas well? And for that matter remove references to "LIGO" from the code as well.Let's format this all as if we're going to offer it upstream, which we in fact should seriously consider doing.
-
@jameson.rollins We should drop those, but probably a little closer to a release.
Getting rid of the set_fe_code_idle and is_cpu_taken_by_rcg_model need to stay around until we either drop the custom kernel or rebuild a new kernel with new symbol names.
The ligo_play_dead and such names can be changed at any time.