Phone number not recognised

When I submit my mobile number in the contact list I get the error "Not a valid phone number". I have a Belgian phone number and I use the format "+32*********".

It might be that that the problem is the country code. Just as a check, I tried to change it from +32 to +33 (keeping the same number) and in that case there was no error.

Hi @daniela.pascucci:

I think there's something else going on with how your number is being input. Belgium is allowed in our messaging service, and in fact, I just checked and there are three other LVK users that have valid +32 phone numbers that are active in GraceDB.

Feel free to message me 1:1 over mattermost with your phone number, or if you're feeling ambitious you can install the phonenumbers package and you can mimic the validation routine (https://git.ligo.org/computing/gracedb/server/-/blob/master/gracedb/alerts/validators.py) that gracedb uses to validate numbers.

Update on this issue:

Daniela and I both verified that the number in question appears to be valid, according to the phonenumbers library in the python interpreter. But that check fails on GraceDB for some reason.

Even when creating the contact manually in the django shell, that validation step still takes place... so we're kind of stuck right now.

One possible way would be to manually create a contact with a different number (33 instead of 32) and mark it as verified:

new_contact = Contact(user=dp, phone='+33XXXXXXXXX', phone_method='B', description='mobile', verified=True)
new_contact.save()

And then completely outside of django, go into psql and manually change the number in the database. I'm reluctant to do that because any subsequent modification of that contact object would inevitably throw an error.

okay, i just went down this rabbit hole, but figured out what the problem is, and it's the version of phonenumbers, for some reason.

Here's the version installed in the gracedb containers:

In [1]: import phonenumbers

In [2]: phonenumbers.__version__
Out[2]: '8.10.22'

In [3]: phone = phonenumbers.parse('+32XXXXXXXXX', 'US')

In [4]: phonenumbers.is_valid_number(phone)
Out[4]: False

and when i upgrade to the latest version:

In [1]: import phonenumbers

In [2]: phonenumbers.__version__
Out[2]: '8.13.16'

In [3]: phone = phonenumbers.parse('+32XXXXXXXXX', 'US')

In [4]: phonenumbers.is_valid_number(phone)
Out[4]: True

uhhh okay? there must have been a bug in phonenumbers that didn't recognize @daniela.pascucci's phone number as valid. I'll upgrade the version in the next release and then ask you to try again next week.

mentioned in commit f6b11eec

mentioned in merge request !152 (merged)

Great! Thanks a lot for looking into this!

@daniela.pascucci could you please try adding your phone contact on gracedb.ligo.org and report back here if it worked?

@alexander.pace yes, the phone contact has been recognised and verified. Thanks again for your help!

closed