Allow for generic site name in Django

Allow for site name to be taken from the env variable DJANGO_ALLOWED_HOSTS.

requested review from @alexander.pace and @daniel.wysocki

assigned to @sara.vallero

mentioned in issue #342

added 12 commits

• ecf69e4f...123762f2 - 12 commits from branch computing/gracedb:master

Compare with previous version

added 1 commit

• 54083a2f - Configurable site name

Compare with previous version

@sara.vallero is the use of DJANGO_ALLOWED_HOSTS appropriate here? This should be able to take multiple hostnames, but the way you use it, it seems to assume there's only one.

Yes, indeed we need only one but with a different domain than ligo.org. Do you prefer if I rewrite the code to take in a list?

@sara.vallero now that I've thought about it more, I think taking a single site is appropriate. However, using DJANGO_ALLOWED_HOSTS isn't appropriate either, as it is a list in some deployments, and we don't want to cause unexpected behavior. Rather than re-use this existing variable, I think it would be better to just add an option to provide the single URL.

What about using DJANGO_PRIMARY_FQDN?

@sara.vallero that sounds good to me.

added 4 commits

• 54083a2f...77f15d0b - 3 commits from branch computing/gracedb:master
• 7bc7bfb8 - Merge branch server:master into update-site

Compare with previous version

added 1 commit

• 9690c432 - Use DJANGO_PRIMARY_FQDN variable

Compare with previous version

added 3 commits

• 7f9f3a7e - 1 commit from branch computing/gracedb:master
• 06c0cd17 - Configurable site name
• 120908ae - Use DJANGO_PRIMARY_FQDN variable

Compare with previous version

marked this merge request as ready

@sara.vallero this looks good to me now. I did spot there's some extra whitespace you added at the end of a file. If you could please apply the code change suggestion to fix that, and rebase against master, I think we're good to merge this in.

@daniel.wysocki done!

mentioned in merge request !130 (closed)

added 1 commit

• e9c01b8b - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 4 commits

• ea94726b - 1 commit from branch computing/gracedb:master
• 1f6cdb24 - Configurable site name
• b2ad395b - Use DJANGO_PRIMARY_FQDN variable
• 1e5baf4b - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

approved this merge request

@sara.vallero I've approved the MR. The pipeline is still failing, but that seems to be happening on other MRs as well, and depends on the runner the job lands on. I'm going to keep hitting retry until it hopefully passes, and then this should be good to merge.

mentioned in merge request !214 (merged)

added 5 commits

• 1e5baf4b...029079e0 - 2 commits from branch computing/gracedb:master
• 2327613f - Configurable site name
• ac2a2c91 - Use DJANGO_PRIMARY_FQDN variable
• 05a4e275 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version