Add more fields to parse GRB voevents; Fixes #154

Finds trigger_id by looking at several different fields now. Added some additional fields to find trigger_duration

marked as a Work In Progress

changed title from Grbfields to WIP: Add more fields to parse GRB voevents; Fixes #154

added 1 commit

• 0a7b9fbf - Changed order for trigger ids so that best ones are first

Compare with previous version

@tanner.prestegard Take a look at this and let me know if we need to make any changes.

Should we add a break statement after this line, as is done for the trigger_duration?

Added it

@brandon.piotrzkowski, thanks for putting this together. I added one suggestion inline. Have you done any testing? If we can coordinate on this, I can set up a gracedb dev server with this code for an hour or so, and you can submit a few events to make sure it is working as expected.

added 1 commit

• 1f30c140 - Added break when finding trigger_id

Compare with previous version

I haven't done any testing yet since I wasn't quite sure how to do it. I have an idea of a few example events to upload so let me know when you can set up a server

I need to define a specific period of time for this testing because I can't leave one of my dev servers untouched for days - I need to use it for other development. Please pick a day and time when I can set a server up for 1 hour for you to test on. I will try to be available on chat during this time so we can make any necessary tweaks (if needed) and iterate rapidly.

Does 12pm central work tomorrow work or is that too close to lunch? I have a lot of flexibility right now so can move it forward or backwards a number of hours.

Sure, that works. I'll ping you on chat around then once it's all set up.

unmarked as a Work In Progress

added 18 commits

• 1f30c140...a7472889 - 17 commits from branch lscsoft:master
• 860ef346 - Add more fields to parse GRB voevents; Fixes #154 (closed)

Compare with previous version

Okay I rebased and squashed all the commits down to one.

merged