Python3
-
Review changes -
-
Download -
Patches
-
Plain diff
Status
This code is as ready as I can get it. Here's what still needs to be done:
- Figure out issue with
lvalert-overseer
. - Check for possible issues on uploading hardware injections (see here. I haven't been able to test it, but it uses
StringIO
which is definitely a cause for concern in terms of Python 2/3 compatibility. - Tag a new version of
lvalert-overseer
, push it to PyPI, and update therequirements.txt
file in this repository to use the new tag.
Suggested strategy for rolling it out
- Test the deployment with the new puppet configuration on gracedb-dev2 or dev1 (more below)
- Deploy on playground and see what happens
- Test this image on gracedb-test
- Tag it
- Deploy on production
To test on UWM VMs
- Delete
/home/gracedb/djangoenv
- As root, run puppet and immediately turn it off so it doesn't revert to the default configuration:
puppet agent -t --environment=gracedb_python3; systemctl stop puppet
- Make sure the repository in
/home/gracedb/bin
is up-to-date. - Do some testing
- If everything looks good, proceed
Final deployment on UWM VMs
- Stop/disable puppet on gracedb-playground
systemctl stop puppet systemctl disable puppet
- Someone at UWM should rebase and merge this MR.
- Setup the dev machines to use this branch and the new configuration.
- As the gracedb user:
cd /home/gracedb/gracedb_project rm -rf ../djangoenv git checkout --track origin/python3
- As root:
puppet agent -t systemctl restart gunicorn systemctl restart lvalert_overseer
- As the gracedb user:
- If all seems good, do the same for playground
- Iterate on any changes needed to the server code
- Once it seems stable on playground, test it on gracedb-test
- If that seems good, merge the code into master and tag it
NOTE: gracedb-dev2 is currently set up for Python 3 both in terms of its Puppet configuration and its code base.
Puppet is currently turned off so that it doesn't revert to the "default" Puppet configuration with Python 2.
Once you're ready to "officially" deploy with Python 3, and the Puppet configuration is merged, just do puppet agent -t
as root on this server to restart Puppet.
Final deployment in AWS
Should be easy - it's all in a Docker image!
Potential issues
The parts of the code that I expect the most issues to occur are:
- VOEvent building (
gracedb/annotations/voevent_utils.py
) since it was completely rewritten - VOEvent ingestion for external events (
gracedb/events/translator.py
) since it was completely rewritten - General string parsing and encoding/decoding
Edited by Alexander Pace
Merge request reports
Compare and
- version 320e04e30c
- version 3130a19b94
- version 3089bd4d68
- version 2915d2dc7a
- version 2821efc41f
- version 27e7939e98
- version 26f14d9d27
- version 25447d63b0
- version 248dc9eb5d
- version 231bd6c67e
- version 224f508978
- version 2187d01ac3
- version 20306de203
- version 19b6a9baeb
- version 187e86682e
- version 17221aab7f
- version 1662fa1f25
- version 158f527f91
- version 149088dea0
- version 13e343c488
- version 1288590b96
- version 110c893aeb
- version 10b6fe8319
- version 921cdd867
- version 888a440b5
- version 7bbb5da21
- version 69adb9cb0
- version 587095575
- version 4799b051d
- version 3ac6910c8
- version 2eccff84b
- version 13b40f43c
- master (base)
- latest versione0e1fa03112 commits,
- version 320e04e30c111 commits,
- version 3130a19b94110 commits,
- version 3089bd4d68109 commits,
- version 2915d2dc7a108 commits,
- version 2821efc41f107 commits,
- version 27e7939e98106 commits,
- version 26f14d9d2796 commits,
- version 25447d63b095 commits,
- version 248dc9eb5d94 commits,
- version 231bd6c67e93 commits,
- version 224f50897892 commits,
- version 2187d01ac391 commits,
- version 20306de20390 commits,
- version 19b6a9baeb89 commits,
- version 187e86682e79 commits,
- version 17221aab7f78 commits,
- version 1662fa1f2577 commits,
- version 158f527f9176 commits,
- version 149088dea075 commits,
- version 13e343c48874 commits,
- version 1288590b9673 commits,
- version 110c893aeb72 commits,
- version 10b6fe831971 commits,
- version 921cdd86770 commits,
- version 888a440b569 commits,
- version 7bbb5da2168 commits,
- version 69adb9cb058 commits,
- version 58709557557 commits,
- version 4799b051d51 commits,
- version 3ac6910c848 commits,
- version 2eccff84b46 commits,
- version 13b40f43c46 commits,
Compare changes
- Side-by-side
- Inline
Files
90Loading