Superevents

Adding superevents to GraceDB, including the necessary models, utility functions, and API resources. This has also resulted in changes to the overall configuration and some parts of the events model.

Many models in the events app, like Labels, Tags, EventLogs, etc. were needed in a similar form for superevents. We were able to completely reuse the existing Label and Tag models for superevents. In other cases, we had to abstract the main functionality of the class into an abstract base class and then implement separate models for events and superevents, due to foreign key requirements. This should leave the current functionality of the events models unchanged.

Some portions of the events API have been modified because of one of the following reasons:

• It didn't make sense and was unnecessarily difficult to duplicate for superevents
• It was inefficient or bad

These changes are documented here: https://bugs.ligo.org/redmine/issues/6133

gracedb/superevents/utils.py

@@ -86,7 +86,7 @@ def create_superevent(submitter, t_start, t_0, t_end, preferred_event=None,
 def update_superevent(superevent, updater, issue_alert=True, **kwargs):
     """
     kwargs which are used as superevent parameters:
-        t_start, t_0, t_end
+        t_start, t_0, t_end, preferred_event
     """
 
     # Extract "updatable" superevent params from kwargs
@@ -115,10 +115,11 @@ def update_superevent(superevent, updater, issue_alert=True, **kwargs):
     if new_params.has_key('preferred_event') and \
         (old_params['preferred_event'] != new_params['preferred_event']):
         # Old preferred event
-        old_msg = ("Removed as preferred event for superevent: "
-            "{superevent_id}").format(superevent_id=superevent.superevent_id)
-        old_log = create_log(updater, old_msg, old_params['preferred_event'],
-            issue_alert=True)
+        if old_params['preferred_event'] is not None:
+            old_msg = ("Removed as preferred event for superevent: "
+                "{superevent_id}").format(superevent_id=superevent.superevent_id)
+            old_log = create_log(updater, old_msg, old_params['preferred_event'],
+                issue_alert=True)
 
         # New preferred event
         new_msg = "Set as preferred event for superevent: {superevent_id}" \
@@ -154,6 +155,7 @@ def create_log(issuer, comment, event_or_superevent, filename="",
         LogModel = EventLog
     else:
         # TODO: raise error
+        logger.error(type(event_or_superevent))
         pass
 
     # Create log object