- don't alllow "." or "-" characters.  prevents errors when used to construct T05whatever filenames and mDNS service names.

- --likelihood-file is renamed to --ranking-stat-output to make its function more clear
- --likelihood-file-cache is renamed to --ranking-stat-output-cache to retain the symmetry
- --reference-likelihood-url is renamed to --ranking-stat-input to make its function more clear

- to --ranking-stat-pdf to more correctly describe what this command line option does.
- also switch to using the load_url() function, instead of load_filename(), to anticipate getting this data from a non-disk location in O3.

Kipp Cannon authored 6 years ago and Kipp Cannon committed 6 years ago

- correct documentation and add missing documentation for command line options
- --help message is reorganized into conceptual groups
- rework input sanity/safety checking and associated error messages
- make --likelihood-url optional, no file will be written if not supplied, and trigger histogram collection will be skipped for performance improvements
- teak gstlal_inspiral_pipe to not set --likelihood-url options on injection jobs

Kipp Cannon authored 6 years ago and Kipp Cannon committed 6 years ago

- when collecting trigger histograms from scratch, initialize the numerator with the signal model so that the resulting ranking statistic file is closer to being in a usable state as-is, without having to mix in the output of gstlal_inspiral_create_prior_diststats
- this has been made possible by the recent change to the numerator's .__iadd__() method that causes overall histogram count to be preserved across marginalization operations
- teach gstlal_inspiral_pipe to disable numerator initialization in the create_prior_diststats jobs since it is not longer required

Kipp Cannon authored 6 years ago and Kipp Cannon committed 6 years ago

- this is a temporary hack to stop the collection of dist stats files for injection jobs.  this should put an end to the endless troubles injection jobs give us in this regard.

- I recently tried to increase the strictness of the command line checking to get more informative error messages out of the code and it looks like I made some checks too strict.  this relaxes them a bit

- confirm the channel list matches the instruments in the time slide vectors
- confirm the reference PSDs, if given, match the instruments in the time slides

- in gstlal_inspiral and gstlal_fake_frames automatically enable PSD tracking when a reference PSD is not given instead of reporting it as an error
- in mkwhitened_multirate_src() require track_psd to be set if psd is None
- flatten initialization of whitener's psd-mode property

- switch numerator and denominator PDFs to a rate.BinnedLnPDF + snglcoinc.LnLRDensity() -based implementation
- add trigger rate tracking feature to denominator, taking advantage of new high-speed coincidence rate machinery in snglcoinc
- add signal rate tracking feature to numerator, taking advantage of pre-computed P(instruments) factors in SNR PDF look-up table
- switch ranking statistic distribution to a rate.BinnedLnPDF -based implementation
- remove search_summary tables, attach all livetime tracking to the trigger rate data in the denominator object

this is a work in progress.  some notable features that are still missing:

- --min-log-L cut based candidate rate reduction feature in gstlal_inspiral is disabled
- online mode for gstlal_inspiral is non-functional

- from CoincsDocument class to Data class

- use Python's own gzip support to check files

- word-wrap and edit comments, reword error messages, etc.

- *** REVERT AFTER O2 ***

gstlal_inspiral: patch for gstlal-inspiral 1.4.2 - fixes bug in reconstruction segments for injections

- glue.ligolw.lsctables.instrument_set_from_ifos() --> instrumentsproperty.get()
- glue.ligolw.lsctables.ifos_from_instrument_set() --> instrumentsproperty.set()

- implement a(n independent) min instruments cut for gracedb uploads
- default is 2, cannot be changed from the command line, can only be changed via the web interface after the program starts

- a variety of import related adjustments and fixes

inspiral_pipe.py: allow for linearly varying ht-gate-threshold
based on max mchirp for a given bin

This reverts commit f0fa6354.

- now the same as the defaults for the pipeline scripts

- not just the ones for which there are gates (i.e., also instruments that
  are in the network being analyzed but that might not be providing any
  data for this particular job)