Skip to content
Snippets Groups Projects

Update SNEWS GCN ingestion to use canvas structure; fixes #449

Merged Brandon Piotrzkowski requested to merge brandon.piotrzkowski/gwcelery:update-snews into main

This MR adapts the changes from !853 (merged) to be used when ingesting SNEWS events.

Edited by Brandon Piotrzkowski

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Brandon Piotrzkowski changed milestone to %O4

    changed milestone to %O4

  • added 1 commit

    Compare with previous version

  • Brandon Piotrzkowski changed title from Update SNEWS GCN ingestion to use canvas structure to Update SNEWS GCN ingestion to use canvas structure; fixes #449

    changed title from Update SNEWS GCN ingestion to use canvas structure to Update SNEWS GCN ingestion to use canvas structure; fixes #449

  • @naresh.adhikari and I checked, and this change would also fix #476 (closed) since gracedb.create_event returns the event dict and not the graceid currently:

    [2022-11-15 09:00:13,779: INFO/MainProcess/MainThread] Task gwcelery.tasks.external_triggers.handle_snews_gcn[2a84b83a-a53a-4c22-b28a-52b4ebb85688] received
    [2022-11-15 09:00:16,051: ERROR/ForkPoolWorker-1/MainThread] Task gwcelery.tasks.external_triggers.handle_snews_gcn[2a84b83a-a53a-4c22-b28a-52b4ebb85688] raised unexpected: HTTPError(<Response [404]>)
    Traceback (most recent call last):
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/ligo/gracedb/utils.py", line 76, in raise_status_exception
        r.raise_for_status()
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/requests/models.py", line 1021, in raise_for_status
        raise HTTPError(http_error_msg, response=self)
    requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://gracedb-test.ligo.org/api/events/%7B'warnings':%20%5B%5D,%20'submitter':%20'emfollow',%20'created':%20'2022-11-15%2017:00:15%20UTC',%20'group':%20'Test',%20'graceid':%20'T340978',%20'pipeline':%20'SNEWS',%20'gpstime':%201352566819.0,%20'reporting_latency':%2014.174052,%20'instruments':%20'',%20'nevents':%20None,%20'offline':%20False,%20'search':%20'Supernova',%20'far':%20None,%20'far_is_upper_limit':%20False,%20'likelihood':%20None,%20'labels':%20%5B%5D,%20'extra_attributes':%20%7B'GRB':%20%7B'ivorn':%20'ivo://nasa.gsfc.gcn/SNEWS#Event2022-11-15T17:00:01.00_1000385-567',%20'author_ivorn':%20'ivo://nasa.gsfc.tan/gcn',%20'author_shortname':%20'SNEWS%20(via%20VO-TAN)',%20'observatory_location_id':%20'GEOLUN',%20'coord_system':%20'UTC-FK5-GEO',%20'ra':%200.0,%20'dec':%200.0,%20'error_radius':%20360.0,%20'how_description':%20'SNEWS:%20SuperNova%20Early%20Warning%20System',%20'how_reference_url':%20'http://gcn.gsfc.nasa.gov/snews.html',%20'T90':%20None,%20'trigger_duration':%20None,%20'designation':%20None,%20'redshift':%20None,%20'trigger_id':%20'1000385'%7D%7D,%20'superevent':%20None,%20'superevent_neighbours':%20%7B%7D,%20'links':%20%7B'neighbors':%20'https://gracedb-test.ligo.org/api/events/T340978/neighbors/',%20'log':%20'https://gracedb-test.ligo.org/api/events/T340978/log/',%20'emobservations':%20'https://gracedb-test.ligo.org/api/events/T340978/emobservation/',%20'files':%20'https://gracedb-test.ligo.org/api/events/T340978/files/',%20'labels':%20'https://gracedb-test.ligo.org/api/events/T340978/labels/',%20'self':%20'https://gracedb-test.ligo.org/api/events/T340978',%20'tags':%20'https://gracedb-test.ligo.org/api/events/T340978/tag/'%7D%7D
    
    During handling of the above exception, another exception occurred:
    
    Traceback (most recent call last):
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/celery/app/trace.py", line 451, in trace_task
        R = retval = fun(*args, **kwargs)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/sentry_sdk/integrations/celery.py", line 204, in _inner
        reraise(*exc_info)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/sentry_sdk/_compat.py", line 56, in reraise
        raise value
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/sentry_sdk/integrations/celery.py", line 199, in _inner
        return f(*args, **kwargs)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/celery/app/trace.py", line 734, in __protected_call__
        return self.run(*args, **kwargs)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/gwcelery/tasks/external_triggers.py", line 66, in handle_snews_gcn
        event = gracedb.get_event(graceid)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/celery/local.py", line 188, in __call__
        return self._get_current_object()(*a, **kw)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/sentry_sdk/integrations/celery.py", line 204, in _inner
        reraise(*exc_info)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/sentry_sdk/_compat.py", line 56, in reraise
        raise value
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/sentry_sdk/integrations/celery.py", line 199, in _inner
        return f(*args, **kwargs)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/celery/app/trace.py", line 735, in __protected_call__
        return orig(self, *args, **kwargs)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/celery/app/task.py", line 392, in __call__
        return self.run(*args, **kwargs)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/celery/app/autoretry.py", line 34, in run
        return task._orig_run(*args, **kwargs)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/gwcelery/tasks/gracedb.py", line 33, in wrapper
        return f(*args, **kwargs)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/gwcelery/tasks/gracedb.py", line 196, in get_event
        return client.event(graceid).json()
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/ligo/gracedb/rest.py", line 505, in event
        return self.get(
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/requests/sessions.py", line 600, in get
        return self.request("GET", url, **kwargs)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/ligo/gracedb/client.py", line 132, in request
        return super().request(
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/requests/sessions.py", line 587, in request
        resp = self.send(prep, **send_kwargs)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/requests/sessions.py", line 708, in send
        r = dispatch_hook("response", hooks, r, **kwargs)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/requests/hooks.py", line 30, in dispatch_hook
        _hook_data = hook(hook_data, **kwargs)
      File "/home/emfollow-test/.local/lib/python3.9/site-packages/ligo/gracedb/utils.py", line 78, in raise_status_exception
        raise HTTPError(response=e.response)
    ligo.gracedb.exceptions.HTTPError: <Response [404]>
  • mentioned in issue #476 (closed)

  • Cody Messick approved this merge request

    approved this merge request

  • added 95 commits

    Compare with previous version

Please register or sign in to reply
Loading