Skip to content
Snippets Groups Projects

Switch to pyproject.toml to support python 3.12; drop python 3.9; fixes #127

2 unresolved threads

Goals of this MR:

  • Add python 3.12; drop python 3.9
  • Fix tests for python 3.12 by dropping setuptools and pkg_resources
  • Switch to pyproject.toml from setup.py
  • Use more standard testing tools from CI templates
  • Fix versioning after dropping versioneer.py
  • Add back in dynamic versioning
Edited by Brandon Piotrzkowski

Merge request reports

Pipeline #673522 passed

Pipeline passed for 0c01b754 on brandon.piotrzkowski:pyproject

Test coverage 92.00% (1.00%) from 3 jobs

Merged by Brandon PiotrzkowskiBrandon Piotrzkowski 5 months ago (Oct 24, 2024 9:10pm UTC)

Loading

Pipeline #673523 passed

Pipeline passed for 5d31bf2a on master

Test coverage 92.00% (1.00%) from 3 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 4 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Brandon Piotrzkowski mentioned in merge request !175 (merged)

    mentioned in merge request !175 (merged)

  • Looks like just adding setuptools for python 3.12 doesn't work: https://git.ligo.org/brandon.piotrzkowski/ligo-followup-advocate/-/jobs/3594145

    My guess is we need to remove this dependence altogether.

  • changed milestone to %Version 1.2.11

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • mentioned in merge request lscsoft/raven!130

  • added 1 commit

    • 1f6b4e3d - Add test for getting version

    Compare with previous version

  • added 1 commit

    • cb03e365 - Remove pkg_resources from dependencies

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • aa07e269 - Don't use test as pytest fixture

    Compare with previous version

  • added 1 commit

    • d8fc7de6 - Add remove nones back to test

    Compare with previous version

  • added 1 commit

    • 5483e439 - Remove test and pkg_resources

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • ed3b6c6a - Use different importing method

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 1fc8069f - Fix importing of files in tests

    Compare with previous version

  • Brandon Piotrzkowski changed the description

    changed the description

  • 27 - python -m pip install pytest-cov pytest-runner -r requirements.txt
    28 script:
    29 - python setup.py test --addopts='-vv -s --cov --cov-report=html --cov-report=term --junitxml=junit.xml'
    23 variables:
    24 PYTEST_OPTIONS: "-vv -s --cov-report=html --import-mode=importlib"
    25 COVERAGE_TARGET: "ligo.followup_advocate"
    26 TESTS_REQUIRE: ".[test]"
    30 27 artifacts:
    31 28 paths:
    32 - htmlcov
    33 expire_in: 1 day
    34
    35 test:python3.9:
    36 extends: .test
    37 image: python:3.9
    29 - htmlcov/
  • Brandon Piotrzkowski marked this merge request as ready

    marked this merge request as ready

  • mentioned in issue #128

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 8e6e6cf6 - Move long description to README.md

    Compare with previous version

  • added 3 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Brandon Piotrzkowski approved this merge request

    approved this merge request

  • Brandon Piotrzkowski enabled an automatic merge when all merge checks for 0c01b754 pass

    enabled an automatic merge when all merge checks for 0c01b754 pass

  • Brandon Piotrzkowski changed title from Switch to pyproject.toml to support python 3.12; drop python 3.9 to Switch to pyproject.toml to support python 3.12; drop python 3.9; fixes #127

    changed title from Switch to pyproject.toml to support python 3.12; drop python 3.9 to Switch to pyproject.toml to support python 3.12; drop python 3.9; fixes #127

  • mentioned in issue #127 (closed)

  • Please register or sign in to reply
    Loading