Switch to pyproject.toml to support python 3.12; drop python 3.9; fixes #127
2 unresolved threads
Goals of this MR:
-
Add python 3.12; drop python 3.9 -
Fix tests for python 3.12 by dropping setuptools
andpkg_resources
-
Switch to pyproject.toml
fromsetup.py
-
Use more standard testing tools from CI templates -
Fix versioning after dropping versioneer.py
-
Add back in dynamic versioning
Edited by Brandon Piotrzkowski
Merge request reports
Activity
- Resolved by Brandon Piotrzkowski
mentioned in merge request !175 (merged)
Looks like just adding
setuptools
for python 3.12 doesn't work: https://git.ligo.org/brandon.piotrzkowski/ligo-followup-advocate/-/jobs/3594145My guess is we need to remove this dependence altogether.
changed milestone to %Version 1.2.11
mentioned in merge request lscsoft/raven!130
- Resolved by Brandon Piotrzkowski
27 - python -m pip install pytest-cov pytest-runner -r requirements.txt 28 script: 29 - python setup.py test --addopts='-vv -s --cov --cov-report=html --cov-report=term --junitxml=junit.xml' 23 variables: 24 PYTEST_OPTIONS: "-vv -s --cov-report=html --import-mode=importlib" 25 COVERAGE_TARGET: "ligo.followup_advocate" 26 TESTS_REQUIRE: ".[test]" 30 27 artifacts: 31 28 paths: 32 - htmlcov 33 expire_in: 1 day 34 35 test:python3.9: 36 extends: .test 37 image: python:3.9 29 - htmlcov/ changed this line in version 27 of the diff
- Resolved by Brandon Piotrzkowski
I don't have a clear way to add back in dynamic versioning yet, so going to create an issue to add this back in sometime in the future.
mentioned in issue #128
added 3 commits
-
8e6e6cf6...84abebc7 - 2 commits from branch
emfollow:master
- 92db55a5 - Switch to pyproject.toml to support python 3.12; drop python 3.9; fixes #127 (closed)
-
8e6e6cf6...84abebc7 - 2 commits from branch
added 1 commit
- 412be072 - Switch to pyproject.toml to support python 3.12; drop python 3.9; fixes #127 (closed)
added 1 commit
- 0c01b754 - Switch to pyproject.toml to support python 3.12; drop python 3.9; fixes #127 (closed)
enabled an automatic merge when all merge checks for 0c01b754 pass
mentioned in issue #127 (closed)
Please register or sign in to reply