noise sub-budgets

It would be nice to have sub-budgets for suspension thermal noise showing the vertical and horizontal contributions from each stage. For example, figure 13 from arXiv:2001.11173.

added enhancement noise labels

changed the description

There should be a quantum sub-budget also (like fig 5 in arXiv:1909.02264).

sub-budgets for all !

e.g. for residual gas we want a breakdown into squeeze film and phase noise, and then each of those broke out into molecular species

changed title from Suspension thermal noise sub-budgets to noise sub-budgets

I have here a suggestion for how to do it the other way around. You define the individual noise items the usual way, and then you can have a collection of noise sources, which just returns the sum of all comprising noise sources. This could, e.g., be plotted instead of the individual noise sources, or added as a reference trace. I'm not completely sure whether I like the implementation as a decorator, but happy to have comments on whether I should make this into a merge request @jameson.rollins @christopher.wipf ?

Here's how it would be used (combining vertical/horizontal sus thermal noise into one sus TN object):

@collects(SuspensionThermalH,SuspensionThermalV)
class SuspensionThermal:
    style = {
        'color': 'blue',
        'label': 'SuspensionThermal'
    }

And here's the decorator that does it:

def collects(*args):
    def collects_decorator(cls):
        class BudgetCollection(nb.Noise):
            style = cls.style
            _noise_classes = args
            def __init__(self, *args, **kwargs):
                super().__init__(*args, **kwargs)
                self._noises = [cls(*args, **kwargs)
                                for cls in self._noise_classes]
            
            def load(self):
                for noise in self._noises:
                    noise.load()
            
            def calc(self):
                return reduce(operator.add, [n.calc() for n in self._noises])

            @property
            def name(self):
                return cls.__name__
            
        return BudgetCollection        
    return collects_decorator

The class that gets the @collects decorator applied isn't really used; I thought about making it a nb.Noise subclass and then monkey-patching it in the decorator, but decided that was pretty messy. I also decided against a normal function (e.g. CombinedNoise = create_collection(Noise1, Noise2), since I wanted it to look and feel very similar to the other noise budgets.

@sebastian.steinlechner There's really no reason to do this because sub-budgets are already supported in the code:

class SuspensionThermal(nb.Budget):
    style = {
        'color': 'blue',
        'label': 'SuspensionThermal'
    }

    noises = [
        SuspensionThermalH,
        SuspensionThermalV,
    ]

I think this issue is just about requesting that they be used in the canonical IFO budgets in gwinc.ifo.

I'm working on making the suspension thermal noise sub-budgets right now. I don't think gwinc currently calculates squeezed film damping or multiple molecular species.

mentioned in issue #63 (closed)

mentioned in merge request !94 (merged)

changed title from noise sub-budgets to suspension thermal sub-budget

mentioned in merge request !105 (merged)

changed title from suspension thermal sub-budget to noise sub-budgets

@kevin.kuns i think this issue has been addressed now, yes?

!94 (merged) took care of the quantum sub-budgets and !105 (merged) will take care of the suspension thermal noise sub-budgets (at least the initial realization). Rana wants "sub-budgets for all !" though and the remaining 1/3 of this issue pertaining to residual gas has not been addressed yet. It seems fine to leave this issue open for now.

A seismic sub-budget (horizontal and vertical) would be useful too.

I was actually thinking about that. I can do that pretty easily.

assigned to @kevin.kuns

mentioned in merge request !110 (merged)

mentioned in commit 10f24a98

Thanks to all @kevin.kuns work, I'm declaring this issue closed. If we want sub-budgets for other noises let's open separate issues.

closed