fix setuptools_scm LookupError bug
1 unresolved thread
1 unresolved thread
Compare changes
+ 4
− 1
@@ -10,7 +10,10 @@ try:
Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 24 March 2025 starting at approximately 8:30am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk.
If setuptools_scm is installed but gwinc is not called from the gwinc directory, a LookupError was previously thrown. Now the version is set to '?.?.?' in this case.
How about instead we just add LookupError to the list of other caught exceptions that are also setting the version:
changed this line in version 4 of the diff
Yeah, that seems cleaner. Whatever fixes the problem.
but you should also remove the other code changes.