Skip to content
Snippets Groups Projects

fix setuptools_scm LookupError bug

Merged fix setuptools_scm LookupError bug
kevin.kuns/pygwinc:setuptools-bug into master
1 unresolved thread
Merged Kevin Kuns requested to merge kevin.kuns/pygwinc:setuptools-bug into master
1 unresolved thread

If setuptools_scm is installed but gwinc is not called from the gwinc directory, a LookupError was previously thrown. Now the version is set to '?.?.?' in this case.

Merge request reports

Merge request pipeline #180822 passed

Stage: dist
Stage: test
Stage: review

Merge request pipeline passed for dab53f3b

Approved by
Jameson Rollins

Merged by Jameson RollinsJameson Rollins 4 years ago (Jan 5, 2021 6:59pm UTC)

Merge details

  • Changes merged into master with a101f0c4.
  • Deleted the source branch.

Pipeline #180823 passed

Stage: dist
Stage: test
Stage: deploy

Pipeline passed for a101f0c4 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
gwinc/__init__.py
10 10 except ModuleNotFoundError:
11 11 try:
12 12 import setuptools_scm
13 __version__ = setuptools_scm.get_version(fallback_version='?.?.?')
13 try:
14 __version__ = setuptools_scm.get_version(fallback_version='?.?.?')
15 except LookupError:
16 __version__ = '?.?.?'
14 17 # FIXME: fallback_version is not available in the buster version
15 18 # (3.2.0-1)
16 19 except (ModuleNotFoundError, TypeError):
  • Kevin Kuns resolved all threads

    resolved all threads

  • Kevin Kuns resolved all threads

    resolved all threads

  • Kevin Kuns added 1 commit

    added 1 commit

    • d4b80287 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Kevin Kuns added 1 commit

    added 1 commit

    Compare with previous version

  • Kevin Kuns added 1 commit

    added 1 commit

    Compare with previous version

  • Kevin Kuns added 9 commits

    added 9 commits

    Compare with previous version

  • Jameson Rollins approved this merge request

    approved this merge request

  • Jameson Rollins mentioned in commit a101f0c4

    mentioned in commit a101f0c4

  • Jameson Rollins merged

    merged

    • Please register or sign in to reply