Add underground Rayleigh NN calculation to newtonian.gravg_rayleigh
This follows the equations in Amann et al. (2020) RSI 91(9) 094504. The functionality for above-ground detectors should not be affected.
Merge request reports
Activity
added 13 commits
-
de1858bf...7c146498 - 12 commits from branch
gwinc:master
- c22fb57b - Add underground Rayleigh NN calculation
-
de1858bf...7c146498 - 12 commits from branch
119 120 zeta = sqrt(qzP / qzS) 120 121 121 122 gnu = k * (1 - zeta) / (qzP - k * zeta) 123 124 if h >= 0: 125 # Harms LRR 126 n = (2 * pi * const.G * rho * exp(-h * k) * gnu)**2 * ground**2 / w**4 122 127 123 n = (2 * pi * const.G * rho * exp(-h * k) * gnu)**2 * ground**2 / w**4 128 else: 129 # Amann et al., eqs. 2-6 (note h is there defined as depth) 130 # The "gamma" cancellation factor is assumed to be 1 131 r0 = k * (1 - zeta) 132 sh = -k * (1 + zeta) * exp(h * k) 133 bh = (2 / 3) * (2 * k * exp(h * qzP) + zeta * qzS * exp(h * qzS)) added 1 commit
- f6cdec3e - Density cancellation for underground Rayleigh
I note that we're not actually testing this new code path. Seems like it would be prudent to add some additional (potentially fictional) IFOs to our test suite to tickle these extra bits. I guess if we can ever get an ET canonical IFO included it will be tested there. I don't think we should block this MR on that though.
Isn't this the point of having actual unit tests, as addressed in !126 (merged)? There are several code paths that are not tested by the canonical IFOs.
I can try to write some unit tests for !121 (merged) following the example of !129 (closed) and then come back here if someone else hasn't done it already. I've been thinking that !121 (merged) needs them anyway and have local tests. I would be fine merging !121 (merged) and !135 (merged) now without them though and adding the tests in separate commits. The quantum code really needs them (in fact I'm not confident that the current code would pass all unit tests that should exist) but !129 (closed) already has them. I think there are code paths in almost all of the other noises that are not tested by the canonical IFOs (or which would not change the noise in the canonical IFOs and therefore would not currently be caught) which should also have tests.
mentioned in commit da7375a3