Skip to content
Snippets Groups Projects

Fixed sky location functionality, and bug fix for extrinsic parameter proposal

Merged Meg Millhouse requested to merge meg.millhouse/bayeswave:new_sky_fix into master

Bring the sky fix branch up to date, and this also fixed the issue with the Psi proposals. Note that there's still something weird going on with the Phi (external parameter) prior recovery when using the orientation proposal, so someone should look into that (this is a bug unrelated to the sky fix stuff)

Usage for fixing the sky location is in the --help output, and is:

  --fixRA                  right ascension in radians of fixed sky location
  --fixDEC                 declination in radians of fixed sky location

if --fixSky is set without --fixRA or --fixDEC then it defaults to ra and dec of 0.

Edited by Meg Millhouse

Merge request reports

Pipeline #83239 passed

Pipeline passed for 98752d5e on meg.millhouse:new_sky_fix

Approval is optional

Merged by Katerina ChatziioannouKaterina Chatziioannou 5 years ago (Oct 10, 2019 11:24am UTC)

Pipeline #84979 passed

Pipeline passed for 3ae12930 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Meg Millhouse changed the description

    changed the description

  • Works as advertised, the only thing I noticed is that the sky location of the first iteration is perhaps still not fixed, see for example

    ldas-pcdev6 trigtime_1233814497.727599621_0.0_0.0_0/chains $ pwd
    /home/katerina.chatziioannou/BayesWave_dev/FixedSky/injection/Run/trigtime_1233814497.727599621_0.0_0.0_0/chains
    ldas-pcdev6 trigtime_1233814497.727599621_0.0_0.0_0/chains $ head signal_params_h0.dat.0 
    1 5.76390810472 0.11552166054 0.499293573993 0.922356326343 5.9274482259 1 1.64715689793 789.056232929 1.28291557475 1.97707847289e-20 3.731542855 
    1 4.513091 -0.127105687408 1.91397017016 -0.185655261748 3.85117192682 1 1.71430614174 480.85479762 19.3123565162 2.29909991652e-22 2.45046778257 
    4 4.513091 -0.127105687408 1.1861154579 0.671109520389 5.3741829378 1 1.98878210648 64.0556589009 1.94743845513 1.12280914916e-21 6.25735579062
  • Meg Millhouse added 1 commit

    added 1 commit

    • 98752d5e - Fix bug where very first iteration of a sky fix job was incorrect

    Compare with previous version

  • Just pushed a bug fix. The first iteration of the chain is now held fixed.

  • mentioned in commit 3ae12930

Please register or sign in to reply
Loading