Skip to content
Snippets Groups Projects

O3 dev

Merged Tyson Littenberg requested to merge tyson-littenberg/bayeswave:O3_dev into master

This request contains much of the groundwork for reconstructing generic polarizations. The default behavior (elliptical polarization) still works. The [h+,hx] needs some debugging. It runs but I don't buy it yet. I'm suggesting to merge now because it does slightly modify the output chain files:

The signal model chain file naming scheme is different (now more similar to the glitch model) e.g. signal_params.dat.0 -> signal_params_h0.dat.0 for the h+ reconstruction. In the elliptical polarization case that is the only output. If you relax that constraint you get signal_params_h0.dat.0 (h+) signal_params_h1.dat.0 (hx) etc.

BayesWavePost output is unchanged, but these changes will need to propagate to the any plotting scripts. megaplot is fine (it doesn't use the chain parameter files). megasky probably needs to substitute signal_params.dat.0 -> signal_params_h0.dat.0. I'm not sure what else downstream may be broken.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • My plan/recommendation is:

    1. create and tag an "O2-stable" branch which users will be directed to, should they desire a fully functional end-to-end pipeline with O2-functionality
    2. I need to add this tag to the CI script so that containers for this "stable" version are available (important for deployment and scaling tests on the OSG and general well-being).
    3. Turns out, the base container I was using to build the BayesWave container no longer exists -- in fact, we haven't had any successful new deployments for >2 months.

    I'll add these to the milestones but my proposed plan of action is:

    • fix the CI/containerization for master
    • branch and tag an O2-stable branch for general use
    • merge these changes into master

    That will give us:

    1. a stable, production-friendly pipeline with O2 functionality
    2. a master branch with the new O3 (polarization) features from which users/developers can report issues with post-processing (if any..)
  • changed milestone to %O3 Deployment

  • All sounds good to me. So what do you need me to do?

  • nothing right now, i'm just overhauling the CI script so we can plug in different branches (not just master). It'll need your approval when it's ready to merge, though

    Actually, this will also be a great opportunity for me to finally inflict my minor pipeline changes on people -- i'll create a merge request for that once O3dev is merged into master

  • James Alexander Clark PhD approved this merge request

    approved this merge request

  • mentioned in commit fb228494

Please register or sign in to reply
Loading