Merge branch 'fix_snr_relbin' into 'master'

BUGFIX: Fix SNR calculation with relative binning

See merge request !1198

bilby/gw/conversion.py

@@ -1407,7 +1407,7 @@ def compute_snrs(sample, likelihood, npool=1):
     if likelihood is not None:
         if isinstance(sample, dict):
             likelihood.parameters.update(sample)
-            signal_polarizations = likelihood.waveform_generator.frequency_domain_strain(sample)
+            signal_polarizations = likelihood.waveform_generator.frequency_domain_strain(likelihood.parameters.copy())
             for ifo in likelihood.interferometers:
                 per_detector_snr = likelihood.calculate_snrs(signal_polarizations, ifo)
                 sample['{}_matched_filter_snr'.format(ifo.name)] =\
@@ -1461,7 +1461,7 @@ def _compute_snrs(args):
     sample = dict(sample).copy()
     likelihood.parameters.update(sample)
     signal_polarizations = likelihood.waveform_generator.frequency_domain_strain(
-        sample
+        likelihood.parameters.copy()
     )
     snrs = list()
     for ifo in likelihood.interferometers:

examples/gw_examples/injection_examples/relative_binning.py

@@ -105,7 +105,6 @@ for key in [
     "phase",
 ]:
     priors[key] = injection_parameters[key]
-priors["fiducial"] = 0
 
 # Perform a check that the prior does not extend to a parameter space longer than the data
 priors.validate_prior(duration, minimum_frequency)