Skip to content

`kombine` incompatible with `scipy` v1.7.0

[Jobs](https://git.ligo.org/lscsoft/bilby/-/jobs/1430632_ are failing because scipy has updated something in the chisquare

Successfully installed scipy-1.7.0
(bilby) 09:21 bilby [master]: $ python test/integration/sampler_run_test.py TestRunningSamplers.test_run_kombine
09:21 bilby INFO    : Running for label 'label', output will be saved to 'outdir'
09:21 bilby INFO    : Search parameters:
09:21 bilby INFO    :   m = Uniform(minimum=0, maximum=5, name=None, latex_label=None, unit=None, boundary='periodic')
09:21 bilby INFO    :   c = Uniform(minimum=-2, maximum=2, name=None, latex_label=None, unit=None, boundary='reflective')
09:21 bilby INFO    : Single likelihood evaluation took 5.348e-05 s
09:21 bilby WARNING : Supplied argument 'npool' not an argument of 'Kombine', removing.
09:21 bilby INFO    : Using sampler Kombine with kwargs {'nwalkers': 100, 'args': [], 'pool': None, 'transd': False, 'lnpost0': None, 'blob0': None, 'iterations': 1000, 'storechain': True, 'processes': 1, 'update_interval': None, 'kde': None, 'kde_size': None, 'spaces': None, 'freeze_transd': False, 'test_steps': 16, 'critical_pval': 0.05, 'max_steps': None, 'burnin_verbose': False}
09:21 bilby INFO    : Running kombine sampler's automatic burnin process
E
======================================================================
ERROR: test_run_kombine (__main__.TestRunningSamplers)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/integration/sampler_run_test.py", line 94, in test_run_kombine
    _ = bilby.run_sampler(
  File "/home/greg/bilby/bilby/core/sampler/__init__.py", line 186, in run_sampler
    result = sampler.run_sampler()
  File "/home/greg/bilby/bilby/core/sampler/kombine.py", line 138, in run_sampler
    self.sampler.burnin(**self.sampler_burnin_kwargs)
  File "/home/greg/software/anaconda3/envs/bilby/lib/python3.8/site-packages/kombine/sampler.py", line 262, in burnin
    if self.consistent_acceptance_rate(window_size=step_size*act, critical_pval=critical_pval):
  File "/home/greg/software/anaconda3/envs/bilby/lib/python3.8/site-packages/kombine/sampler.py", line 743, in consistent_acceptance_rate
    _, p_val = chisquare(nacc, expected_freqs)
  File "/home/greg/software/anaconda3/envs/bilby/lib/python3.8/site-packages/scipy/stats/stats.py", line 6852, in chisquare
    return power_divergence(f_obs, f_exp=f_exp, ddof=ddof, axis=axis,
  File "/home/greg/software/anaconda3/envs/bilby/lib/python3.8/site-packages/scipy/stats/stats.py", line 6694, in power_divergence
    raise ValueError(msg)
ValueError: For each axis slice, the sum of the observed frequencies must agree with the sum of the expected frequencies to a relative tolerance of 1e-08, but the percent differences are:
0.14893617021276595

----------------------------------------------------------------------
Ran 1 test in 0.799s

FAILED (errors=1)