Fix zero spin conversion

This fixes the issue in #588 (closed). It just needed some rearranging of the order in which the various parameters are added and calculation are performed when filling in the missing pieces of the result object.

I've tested this with

1. zero-spin for aligned spin waveform
2. zero-spin for precessing waveform
3. aligned spin for aligned spin waveform
4. aligned spin for precessing spin waveform
5. precessing spins for precessing waveform

and they all finish without errors.

marked this merge request as ready

approved this merge request

approved this merge request

merged

mentioned in commit cdb9a276

changed milestone to %1.1.4

added Bug Conversion labels

mentioned in issue #598 (closed)

mentioned in merge request !1016 (merged)