Modified GRAD_WINDOW_LENGTH calculation for sooner calculation of valid...

This MR includes two fixes and a little extra documentation for the ptemcee module.

• Fixes #638 (closed) by setting all numerical negative infinities (< -10^100) in the mean_log_posterior array to np.nan
• Modified the GRAD_WINDOW_LENGTH over which the gradient of the mean log posterior is calculated to be one of two cases:
  • 2 * ((ndim + 1) // 2) + 1 or
  • 2 * (nwalkers // 2) + 1, the original calculation of this variable in bilby, when ndim <= 3, as otherwise, the gradient calculation fails (because GRAD_WINDOW_LENGTH becomes too small)
• Added docstrings + clear variable names around the calculation of the Gelman-Rubin statistic

added 44 commits

• c7f29664...b6fa00a8 - 43 commits from branch lscsoft:master
• 5c5c58a8 - Resolve conflicts in `ptemcee` module for MR, mainly including the new...

Compare with previous version

added 1 commit

• 70df45d0 - Fix black formatting errors

Compare with previous version

changed milestone to %1.4.0

approved this merge request

added <10 lines label

added 10-100 lines label and removed <10 lines label

unapproved this merge request

Hi @noah.wolfe, thanks for this nice contribution! I hate to be nit-picky, but I think it's best practice to avoid using inline comments. If you think there are some parts of the code that are unclear without the comments, could you either change the names of variables as needed or move longer inline comments to be explained in the docstring? Otherwise all the inline comments could be removed.

added 1 commit

• 137ca8c9 - Move inline comments to check_iteration docstring

Compare with previous version

changed the description

added 60 commits

• 137ca8c9...c65f9f1f - 59 commits from branch lscsoft:master
• 99490561 - Merge branch 'master' of https://git.ligo.org/lscsoft/bilby

Compare with previous version

marked this merge request as ready

added 1 commit

• 81ea6757 - Remove extraneous inlines in get_Q_convergence

Compare with previous version

approved this merge request

resolved all threads

approved this merge request

merged

mentioned in commit d1bcfaaf