Ensure all frequencies are included in the relative binning likelihood calculation

Right now, the relative binning likelihood does not include the final point in the frequency array in its integration limits. This MR ensures that the final point is included. I do not expect this to have a large effect on e.g. the review runs that have been carried out, especially for large duration signals.

Also WIP: including some small improvements to the logic.

added 1 commit

• 0c894b45 - more optimized calculation

Compare with previous version

added 1 commit

• 448efaac - bugfixes

Compare with previous version

added 1 commit

• fabd8ae9 - yet another bugfix

Compare with previous version

changed the description

Thanks for opening the MR. I don't think this fully solves the problem. I think that we also need to apply a similar update to bin_freqs/bin_inds to make sure we're still evaluating the waveform at the edges.

Can you provide some examples of what the difference index attributes/variables are with and without the difference that make the more clear?

added 10-100 lines Likelihood labels

resolved all threads

added 2 commits

• ca39e0e2 - diff_bin_inds --> bin_sizes
• 1b7a9685 - self.diff_bin_inds --> self.bin_sizes

Compare with previous version

added 1 commit

• 0a9fc026 - neaten things

Compare with previous version

added 1 commit

• db665ce6 - add extra line

Compare with previous version

added 9 commits

• f8b004a8 - 1 commit from branch lscsoft:master
• 4352d3c8 - fix issue with last frequency point in array being neglected
• 6d9cd981 - more optimized calculation
• 821e29ac - bugfixes
• ec6c4fc3 - yet another bugfix
• 15cb2a22 - diff_bin_inds --> bin_sizes
• ac0d5bf1 - self.diff_bin_inds --> self.bin_sizes
• cf7632b9 - neaten things
• 767cf74f - add extra line

Compare with previous version

This looks good to me! I just rebased so we can make sure no other changes have impacted this, although I can't believe they did.

approved this merge request

added 22 commits

• 767cf74f...164ca227 - 14 commits from branch lscsoft:master
• 0d93e949 - fix issue with last frequency point in array being neglected
• 94069b07 - more optimized calculation
• 4986158a - bugfixes
• a414486b - yet another bugfix
• 1e048505 - diff_bin_inds --> bin_sizes
• 90495831 - self.diff_bin_inds --> self.bin_sizes
• 2a7b59d6 - neaten things
• 8710d42f - add extra line

Compare with previous version

approved this merge request

changed milestone to %2.4.x

added 14 commits

• 8710d42f...8da18af0 - 6 commits from branch lscsoft:master
• 0b6b86f8 - fix issue with last frequency point in array being neglected
• a530ca61 - more optimized calculation
• ab21f4b1 - bugfixes
• c58a17ca - yet another bugfix
• 7ce900eb - diff_bin_inds --> bin_sizes
• a73f7b36 - self.diff_bin_inds --> self.bin_sizes
• 8df495bc - neaten things
• 4efcb2d1 - add extra line

Compare with previous version

resolved all threads